~peter-sabaini/charm-sudo-pair:add-charm-destructor

Branch merges

Propose for merging

Merged into ~sudo-pair-charmers/charm-sudo-pair:master at revision bbc52e018474e0c52f2bbee6e380e52adeebd453

Giuseppe Petralia: Approve on 2019-01-14

Joel Sing (community): Approve (+1) on 2019-01-11

Andrea Ieri: Pending requested 2019-01-11

Diff: 279 lines (+93/-32)

7 files modified

Makefile (+2/-2)
lib/libsudopair.py (+12/-4)
reactive/sudo_pair.py (+6/-0)
tests/functional/conftest.py (+9/-6)
tests/functional/test_deploy.py (+38/-8)
tests/unit/test_libsudopair.py (+11/-11)
tox.ini (+15/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

b0edeb8... by Peter Sabaini on 2019-01-14

Strip stray tabs from JUJU_REPOSITORY chk, add max complexity

89229f8... by Peter Sabaini on 2019-01-11

Address review comments

ab4a0b5... by Peter Sabaini on 2019-01-10

Add cleanup on unit removal

- Remove sudo.conf and lib on removal of unit

- Add testenv for functesting xenial only

- Optionally preserve test model

- PEP8 fixes

185b866... by Peter Sabaini on 2019-01-10

Address comments, also found a typo requirements

9c7efd3... by Peter Sabaini on 2019-01-09

Fix functional tests

- Build charm before functest, deploy from built charm

- Pin pytest because of https://docs.pytest.org/en/latest/mark.html#marker-revamp-and-iteration

- Add lint target, add Makefile

d133e6b... by Peter Sabaini on 2019-01-08

Update perms based on sudo_pair docs

As per https://github.com/square/sudo_pair/commit/41e7a291256f819a98f7fb4898bbad0e5589499e#diff-29d8221047461bfe69fc0997c8a9cbe6R66

3eaaff6... by Peter Sabaini on 2019-01-07

Fix unittests

- Got a perm. denied reading conffile, update in fixture

- Check for extra_packages seems to be a leftover

5fd51e3... by Andrea Ieri on 2018-11-16

Simplify the file_contents fixture by using cat instead of python

952cfe6... by Andrea Ieri on 2018-11-13

Rewrite of fixtures and tests:

- override the default event loop so we can use module scoped fixtures
- parametrize tests to check both xenial and bionic
- use a temporary model and tear it down when done
- introduce generic fixtures that can be reused
- add docstrings

1c39b8d... by Andrea Ieri on 2018-11-13

Move functional test fixtures to their own conftest file