Merge ~peter-sabaini/charm-sudo-pair:add-logging into ~sudo-pair-charmers/charm-sudo-pair:master
Proposed by
Peter Sabaini
Status: | Superseded |
---|---|
Proposed branch: | ~peter-sabaini/charm-sudo-pair:add-logging |
Merge into: | ~sudo-pair-charmers/charm-sudo-pair:master |
Diff against target: |
242 lines (+119/-5) 8 files modified
actions/actions.py (+11/-1) config.yaml (+14/-0) files/pagerdutyevent.py (+62/-0) lib/libsudopair.py (+17/-1) reactive/sudo_pair.py (+4/-0) templates/sudo_approve.tmpl (+5/-2) templates/sudo_pair.pagerduty.tmpl (+5/-0) tests/unit/test_libsudopair.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Goins | Needs Fixing | ||
Giuseppe Petralia | Pending | ||
Review via email: mp+394340@code.launchpad.net |
This proposal supersedes a proposal from 2020-01-21.
This proposal has been superseded by a proposal from 2021-06-09.
Commit message
Pagerduty alerting, action logging
Ability to have pagerduty alerts triggered on auto-approve. Revamp logging, add logging for remove-sudopair action. Use https proxy to contact the PD events endpoint if set in model config.
To post a comment you must log in.
Small comment on the pagerduty_proxy that may be removed in favor of the juju model-config if any.
Comments in line.
Other than that looks good to me.