Merge ~peter-sabaini/charm-nagios:robustify-install into ~nagios-charmers/charm-nagios:master

Proposed by Peter Sabaini
Status: Merged
Approved by: Peter Sabaini
Approved revision: 8568ba9581ff8281dc11e9eaefedf389a88b9970
Merged at revision: fa015564e63c77d88357e81d8be4d121297ec9a3
Proposed branch: ~peter-sabaini/charm-nagios:robustify-install
Merge into: ~nagios-charmers/charm-nagios:master
Diff against target: 27 lines (+3/-3)
2 files modified
hooks/install (+2/-2)
hooks/templates/localhost_nagios2.cfg.tmpl (+1/-1)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+364101@code.launchpad.net

Commit message

Make install more robust

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

LTGM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision fa015564e63c77d88357e81d8be4d121297ec9a3

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/install b/hooks/install
2index db3e40f..4d1ff11 100755
3--- a/hooks/install
4+++ b/hooks/install
5@@ -35,9 +35,9 @@ if [ -f $CHARM_DIR/files/hostgroups_nagios2.cfg ]; then
6 # Write the new hostgroups_nagios2.cfg file to prevent servers being classified as Debian.
7 cp -v $CHARM_DIR/files/hostgroups_nagios2.cfg /etc/nagios3/conf.d/hostgroups_nagios2.cfg
8 # Remove the services configuration file to eliminiate the need for ssh and localhost groups.
9- rm -v /etc/nagios3/conf.d/services_nagios2.cfg
10+ rm -vf /etc/nagios3/conf.d/services_nagios2.cfg
11 # Remove the ext file to eliminate the need for ssh and localhost groups.
12- rm -v /etc/nagios3/conf.d/extinfo_nagios2.cfg
13+ rm -vf /etc/nagios3/conf.d/extinfo_nagios2.cfg
14 fi
15
16 enable_livestatus=$(config-get enable_livestatus)
17diff --git a/hooks/templates/localhost_nagios2.cfg.tmpl b/hooks/templates/localhost_nagios2.cfg.tmpl
18index 85c756f..d70b915 100644
19--- a/hooks/templates/localhost_nagios2.cfg.tmpl
20+++ b/hooks/templates/localhost_nagios2.cfg.tmpl
21@@ -53,7 +53,7 @@ define service{
22 use generic-service ; Name of service template to use
23 host_name {{ nagios_hostname }}
24 service_description Total Processes
25- check_command check_procs!250!400
26+ check_command check_procs!600!900
27 }
28
29

Subscribers

People subscribed via source and target branches