Merge lp:~peter-pearse/ubuntu/natty/xutils-dev/prop001 into lp:ubuntu/natty/xutils-dev

Proposed by Peter Pearse
Status: Needs review
Proposed branch: lp:~peter-pearse/ubuntu/natty/xutils-dev/prop001
Merge into: lp:ubuntu/natty/xutils-dev
Diff against target: 78 lines (+27/-0)
5 files modified
debian/changelog (+7/-0)
imake/aclocal.m4 (+5/-0)
lndir/aclocal.m4 (+5/-0)
makedepend/aclocal.m4 (+5/-0)
xorg-cf-files/aclocal.m4 (+5/-0)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/xutils-dev/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Review via email: mp+49987@code.launchpad.net

Description of the change

Test always fails with empty file.
I've added reduced text from the x11proto-scrnsaver .xml file
I expect some who speaks XML can come up with something better.

To post a comment you must log in.
Revision history for this message
Peter Pearse (peter-pearse) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote :

My understanding is that this doesn't affect the build of xutils-dev itself, it only matters to software which includes the xorg-macros.m4; and the vast majority of that software is going to get the macros from upstream, not from the Debian or Ubuntu package. So I think the bug you've raised in Debian is the right way to go, and we should wait for the upstream fix to make its way back to us.

review: Disapprove

Unmerged revisions

13. By Peter Pearse

XORG_WITH_XMLTO:: Add some content to the conftest.xml file used for testing whether conversion to text is available

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-08 22:50:19 +0000
3+++ debian/changelog 2011-02-16 15:26:41 +0000
4@@ -1,3 +1,10 @@
5+xutils-dev (1:7.6+1ubuntu1) natty; urgency=low
6+
7+ * XORG_WITH_XMLTO:: Add some content to the conftest.xml file used for
8+ testing whether conversion to text is available
9+
10+ -- Peter Pearse <peter.pearse@linaro.org> Wed, 16 Feb 2011 15:21:41 +0000
11+
12 xutils-dev (1:7.6+1) unstable; urgency=low
13
14 * xorg-cf-files 1.0.4.
15
16=== modified file 'imake/aclocal.m4'
17--- imake/aclocal.m4 2010-10-31 16:35:25 +0000
18+++ imake/aclocal.m4 2011-02-16 15:26:41 +0000
19@@ -1452,6 +1452,11 @@
20 # Test for the ability of xmlto to generate a text target
21 have_xmlto_text=no
22 cat > conftest.xml << "EOF"
23+<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
24+ "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">
25+
26+<book id="saver">
27+</book>
28 EOF
29 AS_IF([test "$have_xmlto" = yes],
30 [AS_IF([$XMLTO --skip-validation txt conftest.xml >/dev/null 2>&1],
31
32=== modified file 'lndir/aclocal.m4'
33--- lndir/aclocal.m4 2010-10-31 16:35:25 +0000
34+++ lndir/aclocal.m4 2011-02-16 15:26:41 +0000
35@@ -1447,6 +1447,11 @@
36 # Test for the ability of xmlto to generate a text target
37 have_xmlto_text=no
38 cat > conftest.xml << "EOF"
39+<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
40+ "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">
41+
42+<book id="saver">
43+</book>
44 EOF
45 AS_IF([test "$have_xmlto" = yes],
46 [AS_IF([$XMLTO --skip-validation txt conftest.xml >/dev/null 2>&1],
47
48=== modified file 'makedepend/aclocal.m4'
49--- makedepend/aclocal.m4 2010-10-31 16:35:25 +0000
50+++ makedepend/aclocal.m4 2011-02-16 15:26:41 +0000
51@@ -1412,6 +1412,11 @@
52 # Test for the ability of xmlto to generate a text target
53 have_xmlto_text=no
54 cat > conftest.xml << "EOF"
55+<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
56+ "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">
57+
58+<book id="saver">
59+</book>
60 EOF
61 AS_IF([test "$have_xmlto" = yes],
62 [AS_IF([$XMLTO --skip-validation txt conftest.xml >/dev/null 2>&1],
63
64=== modified file 'xorg-cf-files/aclocal.m4'
65--- xorg-cf-files/aclocal.m4 2011-01-08 22:50:19 +0000
66+++ xorg-cf-files/aclocal.m4 2011-02-16 15:26:41 +0000
67@@ -1803,6 +1803,11 @@
68 # Test for the ability of xmlto to generate a text target
69 have_xmlto_text=no
70 cat > conftest.xml << "EOF"
71+<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.3//EN"
72+ "http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd">
73+
74+<book id="saver">
75+</book>
76 EOF
77 AS_IF([test "$have_xmlto" = yes],
78 [AS_IF([$XMLTO --skip-validation txt conftest.xml >/dev/null 2>&1],

Subscribers

People subscribed via source and target branches

to all changes: