Merge lp:~peter-pearse/ubuntu/natty/libidn/prop001 into lp:ubuntu/natty/libidn

Proposed by Peter Pearse
Status: Needs review
Proposed branch: lp:~peter-pearse/ubuntu/natty/libidn/prop001
Merge into: lp:ubuntu/natty/libidn
Diff against target: 50 lines (+15/-2)
2 files modified
debian/changelog (+7/-0)
debian/rules (+8/-2)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/libidn/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+51746@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

+ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
+ export DH_OPTIONS += --ignore=debian/libidn11-dev.docs
+endif

This means we would get a package with different content for a native vs. a cross build; we don't want that.

The only file mentioned in libidn11-dev.docs is doc/libidn.pdf, which is in the source tree - so this shouldn't be a cross-building issue at all. Why do you want to ignore this file? Or what causes it to go missing during build?

review: Needs Fixing

Unmerged revisions

22. By Peter Pearse

Ignore missing file, for cross builds skip check.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-12-13 12:56:35 +0000
3+++ debian/changelog 2011-03-01 13:38:43 +0000
4@@ -1,3 +1,10 @@
5+libidn (1.18-1build1ubuntu1) natty; urgency=low
6+
7+ * Ignore missing file.
8+ * For cross builds skip check.
9+
10+ -- Peter Pearse <peter.pearse@linaro.org> Tue, 01 Mar 2011 13:33:37 +0000
11+
12 libidn (1.18-1build1) natty; urgency=low
13
14 * No-change upload to reduce changelogs.
15
16=== modified file 'debian/rules'
17--- debian/rules 2010-01-22 08:28:34 +0000
18+++ debian/rules 2011-03-01 13:38:43 +0000
19@@ -9,7 +9,7 @@
20 ifeq (,$(filter $(DEB_HOST_ARCH),$(NO_JAVA_ARCHES)))
21 ENABLE_JAVA := --enable-java
22 else
23- export DH_OPTIONS=-Nlibidn11-java
24+ export DH_OPTIONS += -Nlibidn11-java
25 endif
26
27 # These are used for cross-compiling and for saving the configure script
28@@ -34,8 +34,11 @@
29
30 # Add here commands to compile the package.
31 $(MAKE)
32+ifeq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
33 $(MAKE) check
34-
35+else
36+ @echo "Skip check during cross builds"
37+endif
38 touch $@
39
40 clean:
41@@ -65,6 +68,9 @@
42 # We have nothing to do by default.
43
44 # Build architecture-dependent files here.
45+ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
46+ export DH_OPTIONS += --ignore=debian/libidn11-dev.docs
47+endif
48 binary-arch: build install
49 dh_testdir
50 dh_testroot

Subscribers

People subscribed via source and target branches

to all changes: