Code review comment for lp:~peter-gjoel/verifydtapn/PTrieWorkflow

Revision history for this message
Jiri Srba (srba) wrote :

Thanks. I am still getting some warnings:

In file included from src/DiscreteVerification/DataStructures/../SearchStrategies/../DataStructures/NonStrictMarking.hpp:15:
src/DiscreteVerification/DataStructures/ptrie.h:388:45: warning: variable 'node'
      is uninitialized when used within its own initialization [-Wuninitialized]
                    node_t* node = get_node(node->_lowpos);
                            ~~~~ ^~~~
src/DiscreteVerification/DataStructures/WorkflowPWList.cpp:192:20: note: in
      instantiation of member function
      'ptrie::ptrie_t<VerifyTAPN::DiscreteVerification::MetaData *>::visit'
      requested here
            passed.visit(visitor);
                   ^
In file included from src/DiscreteVerification/DataStructures/WorkflowPWList.cpp:3:
src/DiscreteVerification/DataStructures/WorkflowPWList.hpp:60:27: warning:
      private field 'last' is not used [-Wunused-private-field]
        NonStrictMarking* last;
                          ^
2 warnings generated.

review: Needs Fixing

« Back to merge proposal