Merge lp:~pete-woods/unity8/remove-indicator-session-hacks into lp:unity8

[Pete Woods]

Remove indicator-session visibility and desktop profile hacks

Remove indicator-session visibility and desktop profile hacks

Note that this is dependent on https://code.launchpad.net/~pete-woods/indicator-session/add-phone-indicator-profiles/+merge/320350

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2872
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3455/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4551/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4579
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4407/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4407/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4407/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4407/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4407/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4407/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3455/rebuild

review: Needs Fixing (continuous-integration)

[lp:~pete-woods/unity8/remove-indicator-session-hacks]

2869. By Michael Terry on 2017-03-21

Support GNOME-style logout DBus API (making the Logout, Reboot, and Shutdown launcher commands work) (LP: #1673229)

Approved by: Albert Astals Cid, Unity8 CI Bot

2870. By Michael Terry on 2017-03-21

Don't lock the screen for guest users or users in the nopasswdlogin group. (LP: #1644237)

Approved by: Josh Arenson, Unity8 CI Bot

2871. By Pete Woods on 2017-03-21

Fix up indicators-client after refactoring (LP: #1672797)

Approved by: Albert Astals Cid, Unity8 CI Bot

2872. By Lukáš Tinkl on 2017-03-21

Reset always-show-osk gsetting on startup to default value (false atm)

Approved by: Albert Astals Cid, Unity8 CI Bot

2873. By Lukáš Tinkl on 2017-03-21

Fix the restored-to position with Miral due to the state changes being async (LP: #1669819)

Approved by: Daniel d'Andrada, Unity8 CI Bot

2874. By Lukáš Tinkl on 2017-03-21

Add a cursor name fallback mapping "grabbing" -> "closedhand" for Breeze

Approved by: Daniel d'Andrada, Unity8 CI Bot

2875. By Michael Zanetti on 2017-03-21

Add support for closing apps from the spread with "Q" (LP: #1670327)

Approved by: Albert Astals Cid, Unity8 CI Bot

2876. By Daniel d'Andrada on 2017-03-21

Really disable the window decoration when in staged mode

Instead of having it only fully translucent (but still catching input).
So that it doesn't eat mouse clicks and taps near the window's top edge (LP: #1670361)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2877. By Lukáš Tinkl on 2017-03-21

Fix unsnapping a maximized window from the panel (LP: #1671721)

Approved by: Albert Astals Cid, Michał Sawicz, Unity8 CI Bot

2878. By Michael Zanetti on 2017-03-21

hide "private" launcher quicklist entries when the greeter is locked (LP: #1667649)

Approved by: Lukáš Tinkl

2879. By Michael Zanetti on 2017-03-21

add surface titles to launcher's quicklist (LP: #1661668)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2880. By Daniel d'Andrada on 2017-03-21

Don't let clients resize their surfaces while in staged (phone/tablet) mode (LP: #1670390)

Approved by: Gerry Boland, Unity8 CI Bot

2881. By Daniel d'Andrada on 2017-03-21

TopLevelWindowModel: don't put hidden windows in the model

From the UI point of view, it's as if they didn't exist. (LP: #1665286)

Approved by: Albert Astals Cid

2882. By Lukáš Tinkl on 2017-03-21

Disable altDrag feature outside windowed mode

Approved by: Albert Astals Cid, Unity8 CI Bot

2883. By Michael Zanetti on 2017-03-21

properly reset the drawer state when cancelling a horizontal drag (LP: #1669536)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2884. By Michael Zanetti on 2017-03-21

fix the focus moving correctly between launcher and drawer (LP: #1669880)

Approved by: Albert Astals Cid, Unity8 CI Bot

2885. By Michael Zanetti on 2017-03-21

unfocus the drawer's textfield when it is moved (LP: #1669839)

Approved by: Albert Astals Cid, Unity8 CI Bot

2886. By Albert Astals Cid on 2017-03-21

Signal aboutToShow (LP: #1664578)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2887. By Albert Astals Cid on 2017-03-21

Support Panel top level items to be disabled

I needed to change the way MenuContent changes its position
from using the highlight to simply setting the contentX directly
since otherwise in some reset cases the position was wrong (LP: #1670694)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2888. By Albert Astals Cid on 2017-03-21

Improve Launcher ←→ touch menu interaction

Needs to move the label from PanelItemRow to Panel because how clipping works in those items (and fixes some other problems too)

If launcher is locked visible:
     * Touch menus show shifted to the right to not overlap
     * Showing the app drawer closes the touch menus
     * Showing the touch menus closes the app drawer

If launcher is not locked visible:
     * Showing the launcher closes the touch menus
     * Showing the touch menus closes the launcher (LP: #1667620, #1671069)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2889. By Albert Astals Cid on 2017-03-21

Fix real world submenus (e.g. kate) not getting their first item selected on open

MenuBar.qml: remove unused function
MenuPopup.qml: Select first item when one arrives if there's no currentItem instead of on completion
unitymenumodel.cpp: trick rowCount() to simulate "real world late" menus
tst_MenuPopup.qml: adapt to unitymenumodel.cpp changes (and make the Up test actually press Up and not Down) (LP: #1666859)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2890. By CI Train Bot Account on 2017-03-21

Releasing 8.15+17.04.20170321-0ubuntu1

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2872
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3505/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4633/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4661
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4489/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4489/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4489/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4489/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4489/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4489/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3505/rebuild

review: Needs Fixing (continuous-integration)

[lp:~pete-woods/unity8/remove-indicator-session-hacks]

2891. By Launchpad Translations on behalf of unity-team on 2017-03-24

Launchpad automatic translations update.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2872
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3515/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4649/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4677/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3515/rebuild

review: Needs Fixing (continuous-integration)

[lp:~pete-woods/unity8/remove-indicator-session-hacks]

2898. By Pete Woods on 2017-03-20

Install the platformtest executable and refer to its path via the TARGET_FILE macro

2899. By Pete Woods on 2017-03-24

Remove indicator-session visibility desktop profile hacks

[Lukáš Tinkl (lukas-kde)]

With this change, the indicator-session no longer displays in unity8. Is there some other indicator-session branch/MP that we need here?

review: Needs Fixing

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2899
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3527/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4670
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2827
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2827
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4698
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4522/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4522/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4522/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4522/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4522/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4522
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4522/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3527/rebuild

review: Approve (continuous-integration)

Unmerged revisions

2899. By Pete Woods on 2017-03-24

Remove indicator-session visibility desktop profile hacks

=== modified file 'plugins/Unity/Indicators/indicatorsmanager.cpp'
--- plugins/Unity/Indicators/indicatorsmanager.cpp	2016-09-11 22:30:30 +0000
+++ plugins/Unity/Indicators/indicatorsmanager.cpp	2017-03-24 11:22:33 +0000
@@ -280,12 +280,10 @@
     new_indicator->init(data->m_fileInfo.fileName(), settings);
 
     // convergence:
-    // 1) enable session indicator
-    // 2) enable keyboard indicator
+    // 1) enable keyboard indicator
     //
     // The rest of the indicators respect their default profile (which is "phone", even on desktop PCs)
-    if ((new_indicator->identifier() == QStringLiteral("indicator-session"))
-            || new_indicator->identifier() == QStringLiteral("indicator-keyboard")) {
+    if (new_indicator->identifier() == QStringLiteral("indicator-keyboard")) {
         new_indicator->setProfile(QString(m_profile).replace(QStringLiteral("phone"), QStringLiteral("desktop")));
     } else {
         new_indicator->setProfile(m_profile);

=== modified file 'qml/Panel/Indicators/IndicatorMenuItemFactory.qml'
--- qml/Panel/Indicators/IndicatorMenuItemFactory.qml	2016-12-14 15:38:18 +0000
+++ qml/Panel/Indicators/IndicatorMenuItemFactory.qml	2017-03-24 11:22:33 +0000
@@ -67,8 +67,6 @@
             "com.canonical.indicator.location": timezoneMenu,
         },
         "indicator-session": {
-            "indicator.user-menu-item": Platform.isPC ? userMenuItem : null,
-            "indicator.guest-menu-item": Platform.isPC ? userMenuItem : null,
             "com.canonical.indicator.switch": Math.min(Screen.width, Screen.height) > units.gu(60) ? switchMenu : null // Desktop mode switch
         },
         "indicator-messages": {
@@ -77,12 +75,6 @@
     }
 
     readonly property var _action_filter_map: {
-        "indicator-session": {
-            "indicator.logout": Platform.isPC ? undefined : null,
-            "indicator.suspend": Platform.isPC ? undefined : null,
-            "indicator.hibernate": Platform.isPC ? undefined : null,
-            "indicator.reboot": Platform.isPC ? undefined : null
-        },
         "indicator-keyboard": {
             "indicator.map": null,
             "indicator.chart": null