Merge lp:~pete-woods/unity-scopes-api/add-system-session-files into lp:unity-scopes-api/devel

Proposed by Pete Woods
Status: Merged
Approved by: Pete Woods
Approved revision: 698
Merged at revision: 698
Proposed branch: lp:~pete-woods/unity-scopes-api/add-system-session-files
Merge into: lp:unity-scopes-api/devel
Prerequisite: lp:~pete-woods/unity-scopes-api/cmake-extras-for-coverage-report
Diff against target: 79 lines (+36/-5)
6 files modified
data/CMakeLists.txt (+17/-0)
data/scope-registry.override (+1/-0)
data/scope-registry.service.in (+7/-0)
data/smart-scopes-proxy.override (+1/-0)
data/smart-scopes-proxy.service.in (+7/-0)
debian/libunity-scopes.install.in (+3/-5)
To merge this branch: bzr merge lp:~pete-woods/unity-scopes-api/add-system-session-files
Reviewer Review Type Date Requested Status
dobey (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+317990@code.launchpad.net

Commit message

Add SystemD session files

Description of the change

Add SystemD session files

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:698
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/70/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1700
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1707
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1482/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1482/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1482/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1482/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1482/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1482
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1482/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-scopes-api-ci/70/rebuild

review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

You don't need the / between $SNAP and before @CMAKE_INSTALL_PREFIX@ here, but shouldn't break things and otherwise looks ok.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2015-10-02 09:11:25 +0000
3+++ data/CMakeLists.txt 2017-02-22 15:17:42 +0000
4@@ -14,6 +14,23 @@
5 configure_file(scope-registry.conf.in scope-registry.conf @ONLY)
6 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/scope-registry.conf DESTINATION ${CMAKE_INSTALL_DATADIR}/upstart/sessions)
7
8+# systemd config for smart scopes proxy
9+configure_file(smart-scopes-proxy.service.in smart-scopes-proxy.service @ONLY)
10+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/smart-scopes-proxy.service DESTINATION lib/systemd/user)
11+
12+# systemd config for scope registry
13+configure_file(scope-registry.service.in scope-registry.service @ONLY)
14+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/scope-registry.service DESTINATION lib/systemd/user)
15+
16+# transitional upstart override files to avoid running twice when upstart runs under systemd
17+install(
18+ FILES
19+ smart-scopes-proxy.override
20+ scope-registry.override
21+ DESTINATION
22+ ${CMAKE_INSTALL_DATADIR}/upstart/systemd-session/upstart
23+)
24+
25 # apport package hook
26 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/libunity-scopes.py libunity-scopes${UNITY_SCOPES_SOVERSION}.py COPYONLY)
27 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libunity-scopes${UNITY_SCOPES_SOVERSION}.py
28
29=== added file 'data/scope-registry.override'
30--- data/scope-registry.override 1970-01-01 00:00:00 +0000
31+++ data/scope-registry.override 2017-02-22 15:17:42 +0000
32@@ -0,0 +1,1 @@
33+manual
34
35=== added file 'data/scope-registry.service.in'
36--- data/scope-registry.service.in 1970-01-01 00:00:00 +0000
37+++ data/scope-registry.service.in 2017-02-22 15:17:42 +0000
38@@ -0,0 +1,7 @@
39+[Unit]
40+Description=Scope registry
41+PartOf=graphical-session.target
42+
43+[Service]
44+ExecStart=$SNAP/@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@/@UNITY_SCOPES_LIB@/scoperegistry
45+Restart=on-failure
46
47=== added file 'data/smart-scopes-proxy.override'
48--- data/smart-scopes-proxy.override 1970-01-01 00:00:00 +0000
49+++ data/smart-scopes-proxy.override 2017-02-22 15:17:42 +0000
50@@ -0,0 +1,1 @@
51+manual
52
53=== added file 'data/smart-scopes-proxy.service.in'
54--- data/smart-scopes-proxy.service.in 1970-01-01 00:00:00 +0000
55+++ data/smart-scopes-proxy.service.in 2017-02-22 15:17:42 +0000
56@@ -0,0 +1,7 @@
57+[Unit]
58+Description=Smart scopes proxy
59+PartOf=graphical-session.target
60+
61+[Service]
62+ExecStart=$SNAP/@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@/@UNITY_SCOPES_LIB@/smartscopesproxy upstart
63+Restart=on-failure
64
65=== modified file 'debian/libunity-scopes.install.in'
66--- debian/libunity-scopes.install.in 2016-02-12 02:24:48 +0000
67+++ debian/libunity-scopes.install.in 2017-02-22 15:17:42 +0000
68@@ -1,8 +1,6 @@
69 var/lib/libunity-scopes/version
70 usr/lib/*/libunity-scopes.so.*
71 usr/lib/*/unity-scopes
72-usr/lib/*/unity-scopes/scoperegistry
73-usr/lib/*/unity-scopes/scoperunner
74-usr/lib/*/unity-scopes/smartscopesproxy
75-usr/share/upstart/sessions/*.conf
76-usr/share/apport/package-hooks/*.py
77+usr/lib/systemd
78+usr/share/upstart
79+usr/share/apport

Subscribers

People subscribed via source and target branches

to all changes: