Merge lp:~pete-woods/unity-mir/window-stack-get-property into lp:unity-mir

[Pete Woods]

Add stub implementation of GetWindowProperties method

This enables the implementation of the BAMF -> WindowStack bridge

Add stub implementation of GetWindowProperties method

This enables the implementation of the BAMF -> WindowStack bridge

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:107
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/100/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-amd64-ci/42
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-armhf-ci/100
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-armhf-ci/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-i386-ci/100

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-mir-ci/100/rebuild

review: Approve (continuous-integration)

[lp:~pete-woods/unity-mir/window-stack-get-property]

108. By Pete Woods on 2013-10-09

Reduce repeated method calls by asking for multiple properties at the same time

[Thomas Voß (thomas-voss)]

From a code perspective: LGTM.
From an architectural perspective, the interface is way to generic and we should start refactoring both the notion of a window stack (we are app-centric, after all) and this very interface to be more specific and to fit better with the rest of the system.

Can you please log bugs for both tasks against unity-mir? Once those are in, I will approve.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:108
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/102/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-armhf-ci/102
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-armhf-ci/102/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-saucy-i386-ci/102

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-mir-ci/102/rebuild

review: Approve (continuous-integration)

[Pete Woods (pete-woods)]

Please see the bugs:

https://bugs.launchpad.net/unity-mir/+bug/1237299

and

https://bugs.launchpad.net/unity-mir/+bug/1237302

[Thomas Voß (thomas-voss)]

> Please see the bugs:
>
> https://bugs.launchpad.net/unity-mir/+bug/1237299
>
> and
>
> https://bugs.launchpad.net/unity-mir/+bug/1237302

Thanks.

review: Approve

=== modified file 'src/modules/Unity/Application/dbuswindowstack.cpp'
--- src/modules/Unity/Application/dbuswindowstack.cpp	2013-10-02 11:50:21 +0000
+++ src/modules/Unity/Application/dbuswindowstack.cpp	2013-10-09 09:02:34 +0000
@@ -68,6 +68,15 @@
     return res;
 }
 
+QStringList DBusWindowStack::GetWindowProperties(unsigned int window_id, const QString &app_id,
+            const QStringList &names)
+{
+    Q_UNUSED(window_id);
+    Q_UNUSED(app_id);
+    Q_UNUSED(names);
+    return QStringList();
+}
+
 QDBusArgument &operator<<(QDBusArgument &a, const AppIdDesktopFile &aidf)
 {
     a.beginStructure();

=== modified file 'src/modules/Unity/Application/dbuswindowstack.h'
--- src/modules/Unity/Application/dbuswindowstack.h	2013-10-02 11:50:21 +0000
+++ src/modules/Unity/Application/dbuswindowstack.h	2013-10-09 09:02:34 +0000
@@ -54,6 +54,7 @@
 
     Q_INVOKABLE Q_SCRIPTABLE AppIdDesktopFile GetAppIdFromPid(unsigned int pid);
     Q_INVOKABLE Q_SCRIPTABLE QList<WindowInfo> GetWindowStack();
+    Q_INVOKABLE Q_SCRIPTABLE QStringList GetWindowProperties(unsigned int window_id, const QString &app_id, const QStringList &names);
 
 signals:
     void FocusedWindowChanged(unsigned int window_id, const QString &app_id, unsigned int stage);