Merge lp:~pete-woods/ubuntu-seeds/ubuntu-touch.xenial-gnome-keyring into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.xenial

Proposed by Pete Woods on 2016-02-17
Status: Merged
Approved by: Łukasz Zemczak on 2016-02-17
Approved revision: 334
Merged at revision: 334
Proposed branch: lp:~pete-woods/ubuntu-seeds/ubuntu-touch.xenial-gnome-keyring
Merge into: lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.xenial
Diff against target: 13 lines (+4/-0)
1 file modified
touch-core (+4/-0)
To merge this branch: bzr merge lp:~pete-woods/ubuntu-seeds/ubuntu-touch.xenial-gnome-keyring
Reviewer Review Type Date Requested Status
Łukasz Zemczak 2016-02-17 Approve on 2016-02-17
Review via email: mp+286335@code.launchpad.net

Commit Message

Add gnome-keyring, libp11-kit-gnome-keyring and libpam-gnome-keyring to allow VPN password storage

Description of the Change

Add gnome-keyring, libp11-kit-gnome-keyring and libpam-gnome-keyring to allow VPN password storage

To post a comment you must log in.
334. By Pete Woods on 2016-02-17

Add gnome-keyring, libp11-kit-gnome-keyring and libpam-gnome-keyring to allow VPN password storage

Łukasz Zemczak (sil2100) wrote :

Looks good. As per your examination this will use up ~4MB of additional disk space - but it's all good as we would really need this. The product team (Pat) approves of this change as well.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'touch-core'
2--- touch-core 2015-12-17 14:16:06 +0000
3+++ touch-core 2016-02-17 15:17:01 +0000
4@@ -70,6 +70,10 @@
5 * ciborium
6 * openvpn
7 * qtubuntu-sensors
8+# Credential storage
9+ * gnome-keyring
10+ * libp11-kit-gnome-keyring
11+ * libpam-gnome-keyring
12
13 == Multimedia ==
14

Subscribers

People subscribed via source and target branches