Merge lp:~pete-woods/storage-framework/cmake-extras-compatibility into lp:storage-framework

Proposed by Pete Woods
Status: Rejected
Rejected by: Michi Henning
Proposed branch: lp:~pete-woods/storage-framework/cmake-extras-compatibility
Merge into: lp:storage-framework
Diff against target: 25 lines (+2/-2)
2 files modified
CMakeLists.txt (+1/-1)
debian/control.in (+1/-1)
To merge this branch: bzr merge lp:~pete-woods/storage-framework/cmake-extras-compatibility
Reviewer Review Type Date Requested Status
Michi Henning (community) Disapprove
Review via email: mp+312724@code.launchpad.net

Commit message

Compatibility with unversioned cmake-extras modules

Description of the change

Compatibility with unversioned cmake-extras modules

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

Works fine, thanks!

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

Rejecting this simply because we had problems with the silo. We've since merged the fix, so all is well.

review: Disapprove

Unmerged revisions

15. By Pete Woods

Compatibility with unversioned cmake-extras modules

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-10-31 09:03:32 +0000
3+++ CMakeLists.txt 2016-12-07 17:29:17 +0000
4@@ -104,7 +104,7 @@
5 include(CTest)
6 enable_testing()
7
8-include(EnableCoverageReport)
9+find_package(CoverageReport)
10
11 include(GNUInstallDirs)
12
13
14=== modified file 'debian/control.in'
15--- debian/control.in 2016-09-30 01:47:57 +0000
16+++ debian/control.in 2016-12-07 17:29:17 +0000
17@@ -4,7 +4,7 @@
18 Maintainer: Ubuntu Core Developers <ubuntu-devel-discuss@lists.ubuntu.com>
19 Standards-Version: 3.9.6
20 Build-Depends: cmake,
21- cmake-extras (>= 0.4),
22+ cmake-extras (>= 0.10),
23 debhelper (>= 9),
24 devscripts,
25 doxygen,

Subscribers

People subscribed via source and target branches

to all changes: