Merge lp:~pete-woods/keeper/cmake-extras-compatibility into lp:keeper

Proposed by Pete Woods
Status: Rejected
Rejected by: Pete Woods
Proposed branch: lp:~pete-woods/keeper/cmake-extras-compatibility
Merge into: lp:keeper
Diff against target: 39 lines (+3/-4)
3 files modified
CMakeLists.txt (+1/-1)
debian/control (+1/-1)
src/client/qml-plugin/CMakeLists.txt (+1/-2)
To merge this branch: bzr merge lp:~pete-woods/keeper/cmake-extras-compatibility
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
Review via email: mp+312717@code.launchpad.net

Commit message

Compatibility with unversioned cmake-extras modules

Description of the change

Compatibility with unversioned cmake-extras modules

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

Looks good.

review: Approve
Revision history for this message
Pete Woods (pete-woods) wrote :

Seems like someone already fixed this.

Revision history for this message
Charles Kerr (charlesk) wrote :

:D

Unmerged revisions

93. By Pete Woods

Compatibility with unversioned cmake-extras modules

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-08-26 09:30:11 +0000
3+++ CMakeLists.txt 2016-12-07 17:18:36 +0000
4@@ -272,7 +272,7 @@
5 include(CTest)
6 enable_testing()
7
8-include(EnableCoverageReport)
9+find_package(CoverageReport)
10
11 add_subdirectory(data)
12 add_subdirectory(src)
13
14=== modified file 'debian/control'
15--- debian/control 2016-08-26 08:48:05 +0000
16+++ debian/control 2016-12-07 17:18:36 +0000
17@@ -3,7 +3,7 @@
18 Priority: optional
19 Maintainer: Unity API Team <unityapiteam@lists.canonical.com>
20 Build-Depends: cmake,
21- cmake-extras,
22+ cmake-extras (>= 0.10),
23 dbus,
24 debhelper (>= 9),
25 # for building the code:
26
27=== modified file 'src/client/qml-plugin/CMakeLists.txt'
28--- src/client/qml-plugin/CMakeLists.txt 2016-08-26 09:30:11 +0000
29+++ src/client/qml-plugin/CMakeLists.txt 2016-12-07 17:18:36 +0000
30@@ -6,8 +6,7 @@
31 add_definitions(-DKEEPER_MAJOR=${KEEPER_MAJOR})
32 add_definitions(-DKEEPER_MINOR=${KEEPER_MINOR})
33
34-include(QmlPlugins)
35-
36+find_package(QmlPlugins)
37 find_package(Qt5Quick REQUIRED)
38
39 include_directories(

Subscribers

People subscribed via source and target branches

to all changes: