Merge lp:~pete-woods/cmake-extras/drop-deprecated-macros-lp1563573 into lp:cmake-extras

Proposed by Pete Woods
Status: Merged
Approved by: Charles Kerr
Approved revision: 73
Merged at revision: 73
Proposed branch: lp:~pete-woods/cmake-extras/drop-deprecated-macros-lp1563573
Merge into: lp:cmake-extras
Diff against target: 96 lines (+11/-27)
9 files modified
CMakeLists.txt (+0/-8)
debian/changelog (+8/-0)
debian/control (+1/-2)
debian/rules (+2/-7)
modules/EnableCoverageReport.cmake (+0/-2)
modules/FormatCode.cmake (+0/-2)
modules/QmlPlugins.cmake (+0/-2)
modules/UseDoxygen.cmake (+0/-2)
modules/UseGSettings.cmake (+0/-2)
To merge this branch: bzr merge lp:~pete-woods/cmake-extras/drop-deprecated-macros-lp1563573
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+321718@code.launchpad.net

Commit message

Drop deprecated macros

Description of the change

Drop deprecated macros

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-11-30 05:50:48 +0000
+++ CMakeLists.txt 2017-04-03 15:09:41 +0000
@@ -10,11 +10,3 @@
10 USE_SOURCE_PERMISSIONS10 USE_SOURCE_PERMISSIONS
11)11)
1212
13# Modules installed directly to CMAKE_ROOT
14# TODO: migrate these to the above tree, since installing to
15# CMAKE_ROOT is frowned upon.
16install(
17 DIRECTORY "modules/"
18 DESTINATION "${CMAKE_ROOT}/Modules/"
19 USE_SOURCE_PERMISSIONS
20)
2113
=== modified file 'debian/changelog'
--- debian/changelog 2017-03-10 12:38:01 +0000
+++ debian/changelog 2017-04-03 15:09:41 +0000
@@ -1,3 +1,11 @@
1cmake-extras (1.4-0ubuntu1) UNRELEASED; urgency=medium
2
3 [ Pete Woods ]
4 * Drop deprecated modules now that no-one is using them any more,
5 fixing bug (LP: #1563573).
6
7 -- Pete <pete.woods@canonical.com> Mon, 03 Apr 2017 16:01:33 +0100
8
1cmake-extras (1.3+17.04.20170310-0ubuntu1) zesty; urgency=medium9cmake-extras (1.3+17.04.20170310-0ubuntu1) zesty; urgency=medium
210
3 [ Pete ]11 [ Pete ]
412
=== modified file 'debian/control'
--- debian/control 2016-12-01 07:23:24 +0000
+++ debian/control 2017-04-03 15:09:41 +0000
@@ -15,7 +15,6 @@
15Architecture: all15Architecture: all
16Multi-Arch: foreign16Multi-Arch: foreign
17Depends: ${misc:Depends},17Depends: ${misc:Depends},
18 cmake (>= ${cmake:Version}),18 cmake (>= 3.1),
19 cmake (<< ${cmake:nextMajor}),
20Description: Extra CMake utility modules.19Description: Extra CMake utility modules.
21 Modules for coverage testing, building gtest, doxygen documentation, and more.20 Modules for coverage testing, building gtest, doxygen documentation, and more.
2221
=== modified file 'debian/rules'
--- debian/rules 2016-11-23 06:20:41 +0000
+++ debian/rules 2017-04-03 15:09:41 +0000
@@ -1,9 +1,4 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
2%:2%:
3 dh $@ --fail-missing3 dh $@ --fail-missing --parallel
44
5CMAKE_VERSION=$(shell dpkg-query --show --showformat='$${version}' cmake | cut -f1,2 -d.)
6
7override_dh_gencontrol:
8 dh_gencontrol -- \
9 -Vcmake:Version=$(CMAKE_VERSION) -Vcmake:nextMajor=$(CMAKE_VERSION).z
105
=== removed directory 'modules'
=== removed file 'modules/EnableCoverageReport.cmake'
--- modules/EnableCoverageReport.cmake 2016-12-08 09:57:20 +0000
+++ modules/EnableCoverageReport.cmake 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1message(DEPRECATION "include(EnableCoverageReport) is deprecated. Use find_package(CoverageReport) instead")
2find_package(CoverageReport)
30
=== removed file 'modules/FormatCode.cmake'
--- modules/FormatCode.cmake 2016-12-07 15:30:09 +0000
+++ modules/FormatCode.cmake 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1message(DEPRECATION "include(FormatCode) is deprecated. Use find_package(FormatCode) instead")
2find_package(FormatCode)
30
=== removed file 'modules/QmlPlugins.cmake'
--- modules/QmlPlugins.cmake 2016-12-07 15:30:09 +0000
+++ modules/QmlPlugins.cmake 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1message(DEPRECATION "include(QmlPlugins) is deprecated. Use find_package(QmlPlugins) instead")
2find_package(QmlPlugins)
30
=== removed file 'modules/UseDoxygen.cmake'
--- modules/UseDoxygen.cmake 2016-12-07 15:30:09 +0000
+++ modules/UseDoxygen.cmake 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1message(DEPRECATION "include(UseDoxygen) is deprecated. Use find_package(DoxygenBuilder) instead")
2find_package(DoxygenBuilder)
30
=== removed file 'modules/UseGSettings.cmake'
--- modules/UseGSettings.cmake 2016-12-07 15:30:09 +0000
+++ modules/UseGSettings.cmake 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1message(DEPRECATION "include(UseGSettings) is deprecated. Use find_package(GSettings) instead")
2find_package(GSettings)

Subscribers

People subscribed via source and target branches

to all changes: