Merge lp:~pete-woods/click-reviewers-tools/childscopes-field into lp:click-reviewers-tools

Proposed by Pete Woods on 2015-01-20
Status: Merged
Merged at revision: 354
Proposed branch: lp:~pete-woods/click-reviewers-tools/childscopes-field
Merge into: lp:click-reviewers-tools
Diff against target: 32 lines (+4/-0)
2 files modified
clickreviews/cr_scope.py (+3/-0)
clickreviews/tests/test_cr_scope.py (+1/-0)
To merge this branch: bzr merge lp:~pete-woods/click-reviewers-tools/childscopes-field
Reviewer Review Type Date Requested Status
Daniel Holbach (community) 2015-01-20 Approve on 2015-01-20
Review via email: mp+247004@code.launchpad.net

Commit Message

Add childscopes field to recognised list

Description of the Change

Add childscopes field to recognised list

Please see the documentation of the scope config files here: http://bazaar.launchpad.net/~unity-team/unity-scopes-api/trunk/view/head:/CONFIGFILES

To post a comment you must log in.
355. By Pete Woods on 2015-01-20

Add documentation link

Daniel Holbach (dholbach) wrote :

Thanks. Merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clickreviews/cr_scope.py'
2--- clickreviews/cr_scope.py 2014-11-21 18:33:17 +0000
3+++ clickreviews/cr_scope.py 2015-01-20 13:35:46 +0000
4@@ -22,6 +22,8 @@
5 import os
6 import re
7
8+# Please refer to the config file documentation at:
9+# http://bazaar.launchpad.net/~unity-team/unity-scopes-api/trunk/view/head:/CONFIGFILES
10
11 KNOWN_SECTIONS = set(["ScopeConfig", "Appearance"])
12
13@@ -104,6 +106,7 @@
14 'description',
15 'displayname']
16 optional = ['art',
17+ 'childscopes',
18 'hotkey',
19 'icon',
20 'idletimeout',
21
22=== modified file 'clickreviews/tests/test_cr_scope.py'
23--- clickreviews/tests/test_cr_scope.py 2014-11-21 18:36:36 +0000
24+++ clickreviews/tests/test_cr_scope.py 2015-01-20 13:35:46 +0000
25@@ -43,6 +43,7 @@
26 '''Stub configparser file'''
27 config_dict = {
28 'ScopeRunner': "%s" % self.default_appname,
29+ 'ChildScopes': 'Child1',
30 'DisplayName': 'Foo',
31 'Description': 'Some description',
32 'Author': 'Foo Ltd.',

Subscribers

People subscribed via source and target branches