Merge lp:~pete-woods/account-plugins/google-youtube into lp:account-plugins

Proposed by Pete Woods on 2014-07-01
Status: Rejected
Rejected by: Alberto Mardegan on 2014-07-01
Proposed branch: lp:~pete-woods/account-plugins/google-youtube
Merge into: lp:account-plugins
Diff against target: 50 lines (+12/-1)
4 files modified
Makefile.am (+1/-0)
data/providers/google.provider.in.in (+1/-1)
data/services/google-youtube.service.in (+9/-0)
debian/account-plugin-google.install (+1/-0)
To merge this branch: bzr merge lp:~pete-woods/account-plugins/google-youtube
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2014-07-01 Disapprove on 2014-07-01
PS Jenkins bot (community) continuous-integration Approve on 2014-07-01
Review via email: mp+225131@code.launchpad.net

Commit message

Google: Add Youtube service

Description of the change

Add the Youtube service to enable the newly written Youtube scope to access Youtube accounts.

To post a comment you must log in.
Alberto Mardegan (mardy) wrote :

As discussed in IRC, the service file will be shipped by the youtube scope.

review: Disapprove

Unmerged revisions

139. By Pete Woods on 2014-07-01

Google: Add Youtube service

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.am'
2--- Makefile.am 2014-03-31 08:21:46 +0000
3+++ Makefile.am 2014-07-01 10:39:24 +0000
4@@ -89,6 +89,7 @@
5 data/services/foursquare-microblog.service.in \
6 data/services/google-drive.service.in \
7 data/services/google-im.service.in \
8+ data/services/google-youtube.service.in \
9 data/services/identica-microblog.service.in \
10 data/services/linkedin-microblog.service.in \
11 data/services/instagram-microblog.service.in \
12
13=== modified file 'data/providers/google.provider.in.in'
14--- data/providers/google.provider.in.in 2014-03-07 15:03:19 +0000
15+++ data/providers/google.provider.in.in 2014-07-01 10:39:24 +0000
16@@ -19,7 +19,7 @@
17 <setting name="TokenPath">o/oauth2/token</setting>
18 <setting name="RedirectUri">https://wiki.ubuntu.com/</setting>
19 <setting name="ResponseType">code</setting>
20- <setting name="Scope" type="as">['https://docs.google.com/feeds/','https://www.googleapis.com/auth/googletalk','https://www.googleapis.com/auth/userinfo.email','https://www.googleapis.com/auth/userinfo.profile','https://picasaweb.google.com/data/','https://mail.google.com/','https://www.google.com/m8/feeds/','https://www.googleapis.com/auth/calendar','https://www.googleapis.com/auth/carddav']</setting>
21+ <setting name="Scope" type="as">['https://docs.google.com/feeds/','https://www.googleapis.com/auth/googletalk','https://www.googleapis.com/auth/userinfo.email','https://www.googleapis.com/auth/userinfo.profile','https://picasaweb.google.com/data/','https://mail.google.com/','https://www.google.com/m8/feeds/','https://www.googleapis.com/auth/calendar','https://www.googleapis.com/auth/carddav','https://www.googleapis.com/auth/youtube']</setting>
22 <setting name="ClientId">@GOOGLE_CLIENT_ID@</setting>
23 <setting name="ClientSecret">@GOOGLE_CLIENT_SECRET@</setting>
24 <setting name="AllowedSchemes" type="as">['https','http']</setting>
25
26=== added file 'data/services/google-youtube.service.in'
27--- data/services/google-youtube.service.in 1970-01-01 00:00:00 +0000
28+++ data/services/google-youtube.service.in 2014-07-01 10:39:24 +0000
29@@ -0,0 +1,9 @@
30+<?xml version="1.0" encoding="UTF-8"?>
31+<service id="google-youtube">
32+ <type>sharing</type>
33+ <name>Youtube</name>
34+ <icon>youtube</icon>
35+ <provider>google</provider>
36+ <translations>account-plugins</translations>
37+</service>
38+
39
40=== modified file 'debian/account-plugin-google.install'
41--- debian/account-plugin-google.install 2013-08-01 14:34:21 +0000
42+++ debian/account-plugin-google.install 2014-07-01 10:39:24 +0000
43@@ -1,6 +1,7 @@
44 etc/signon-ui/webkit-options.d/accounts.google.com.conf
45 usr/share/accounts/services/google-drive.service
46 usr/share/accounts/services/google-im.service
47+usr/share/accounts/services/google-youtube.service
48 usr/share/accounts/services/picasa.service
49 usr/share/accounts/providers/google.provider
50 usr/share/accounts/qml-plugins/google/Main.qml

Subscribers

People subscribed via source and target branches

to all changes: