Merge lp:~percona-toolkit-dev/percona-toolkit/typo-in-pt-variable-advisor-1303388 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.11

Proposed by Frank Cizmich
Status: Merged
Approved by: Daniel Nichter
Approved revision: 617
Merged at revision: 623
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/typo-in-pt-variable-advisor-1303388
Merge into: lp:~percona-toolkit-dev/percona-toolkit/release-2.2.11
Diff against target: 24 lines (+3/-3)
1 file modified
bin/pt-variable-advisor (+3/-3)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/typo-in-pt-variable-advisor-1303388
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Review via email: mp+234739@code.launchpad.net

Description of the change

expire_logs_days variable was incorrectly named expire_log_days.
This prevented the tool from issuing the corresponding warning when it was set to 0 with binlog ON.

To post a comment you must log in.
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

You can merge clear-cut, unarguable fixes like this without a review.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-variable-advisor'
2--- bin/pt-variable-advisor 2014-08-05 20:37:42 +0000
3+++ bin/pt-variable-advisor 2014-09-15 20:12:17 +0000
4@@ -3601,10 +3601,10 @@
5 },
6 },
7 {
8- id => 'expire_log_days',
9+ id => 'expire_logs_days',
10 code => sub {
11 my ( %args ) = @_;
12- return _var_eq($args{variables}->{expire_log_days}, 0)
13+ return _var_eq($args{variables}->{expire_logs_days}, 0)
14 && _var_seq($args{variables}->{log_bin}, "ON");
15 },
16 },
17@@ -5720,7 +5720,7 @@
18 Most applications should use the default REPEATABLE-READ transaction
19 isolation level, or in a few cases READ-COMMITTED.
20
21-=item expire_log_days
22+=item expire_logs_days
23
24 severity: warn
25

Subscribers

People subscribed via source and target branches

to all changes: