Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-sync-binlog-format-only-if-not-statement into lp:percona-toolkit/2.1

[Baron Schwartz]

[Daniel Nichter (daniel-nichter)]

review: Approve

=== modified file 'bin/pt-table-sync'
--- bin/pt-table-sync	2012-06-11 19:48:00 +0000
+++ bin/pt-table-sync	2012-06-12 01:33:20 +0000
@@ -8884,9 +8884,35 @@
    
    # Ensure statement-based replication.
    # http://code.google.com/p/maatkit/issues/detail?id=95
-   $sql = q{/*!50105 SET @@binlog_format='STATEMENT'*/};
-   PTDEBUG && _d($dbh, $sql);
-   $dbh->do($sql);
+   # https://bugs.launchpad.net/percona-toolkit/+bug/919352
+   # The tool shouldn't blindly attempt to change binlog_format;
+   # instead, it should check if it's already set to STATEMENT.
+   # This is becase starting with MySQL 5.1.29, changing the format
+   # requires a SUPER user.
+   my $vp = new VersionParser();
+   if ( $vp->version_ge($dbh, '5.1.5') ) {
+      $sql = 'SELECT @@binlog_format';
+      PTDEBUG && _d($dbh, $sql);
+      my ($original_binlog_format) = $dbh->selectrow_array($sql);
+      PTDEBUG && _d('Original binlog_format:', $original_binlog_format);
+      if ( $original_binlog_format !~ /STATEMENT/i ) {
+         $sql = q{/*!50108 SET @@binlog_format := 'STATEMENT'*/};
+         eval {
+            PTDEBUG && _d($dbh, $sql);
+            $dbh->do($sql);
+         };
+         if ( $EVAL_ERROR ) {
+            die "Failed to $sql: $EVAL_ERROR\n"
+               . "This tool requires binlog_format=STATEMENT, "
+               . "but the current binlog_format is set to "
+               ."$original_binlog_format and an error occurred while "
+               . "attempting to change it.  If running MySQL 5.1.29 or newer, "
+               . "setting binlog_format requires the SUPER privilege.  "
+               . "You will need to manually set binlog_format to 'STATEMENT' "
+               . "before running this tool.\n";
+         }
+      }
+   }
 
    if ( $o->get('transaction') ) {
       my $sql = "SET SESSION TRANSACTION ISOLATION LEVEL REPEATABLE READ";