Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-does-not-work-with-sql_mode-ONLY_FULL_GROUP_BY-1019479 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.13
Proposed by
Frank Cizmich
Status: | Merged |
---|---|
Approved by: | Daniel Nichter |
Approved revision: | 612 |
Merged at revision: | 620 |
Proposed branch: | lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-does-not-work-with-sql_mode-ONLY_FULL_GROUP_BY-1019479 |
Merge into: | lp:~percona-toolkit-dev/percona-toolkit/release-2.2.13 |
Diff against target: |
67 lines (+39/-0) 2 files modified
bin/pt-table-checksum (+20/-0) t/pt-table-checksum/basics.t (+19/-0) |
To merge this branch: | bzr merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-does-not-work-with-sql_mode-ONLY_FULL_GROUP_BY-1019479 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Nichter | Approve | ||
Review via email: mp+245681@code.launchpad.net |
Description of the change
Problem:
pt-table-checksum fails when the sql_mode ONLY_FULL_GROUP_BY is set, even though the query that fails is deterministic.
Solution:
disable this mode during the session. (leave all other modes on)
Notes:
- tried to modify the query to comply, but it is dynamically generated on the fly according to different parameters so a solution along these lines was either not elegant or not efficient.
- important issue to fix for upcoming 5.7 version since this sql_mode will be on by default.
To post a comment you must log in.