Merge lp:~percona-toolkit-dev/percona-toolkit/pt-osc-asks-for-confirmation-when-alter-foreign-key-method-none-1329422 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.9

[Frank Cizmich]

Issues a warning and asks for confirmation when alter-foreign-key-method = none
Can be overriden with --force

=== modified file 'bin/pt-online-schema-change'
--- bin/pt-online-schema-change	2014-06-05 07:24:48 +0000
+++ bin/pt-online-schema-change	2014-06-30 17:03:42 +0000
@@ -7860,6 +7860,16 @@
          $o->save_error("Invalid --alter-foreign-keys-method value: $alter_fk_method");
       }
 
+      # Issue a strong warning if alter-foreign-keys-method = none
+      if ( $alter_fk_method eq 'none' && !$o->get('force') ) {
+         print STDERR "WARNING! Using alter-foreign-keys-method = \"none\". This will typically cause foreign key violations!\nThis method of handling foreign key constraints is only provided so that the database administrator can disable the tool’s built-in functionality if desired.\n\nContinue anyway? (y/N)";
+         my $response;
+         chomp($response = <STDIN>);
+         if ($response !~ /y|(yes)/i) { 
+            exit 1;
+         }
+      }
+
       if ( $alter_fk_method eq 'drop_swap' && !$o->get('drop-new-table') ) {
          $o->save_error("--alter-foreign-keys-method=drop_swap does not work with --no-drop-new-table.");
       }
@@ -11025,6 +11035,10 @@
 documentation and understand how to use this tool.  If you have not read the
 documentation, then do not specify this option.
 
+=item --force
+
+This options bypasses confirmation in case of using alter-foreign-keys-method = none , which might break foreign key constraints.
+
 =item --help
 
 Show help and exit.

=== modified file 't/pt-online-schema-change/basics.t'
--- t/pt-online-schema-change/basics.t	2013-11-27 00:27:49 +0000
+++ t/pt-online-schema-change/basics.t	2014-06-30 17:03:42 +0000
@@ -591,7 +591,7 @@
    test_type    => "new_engine",
    new_engine   => "innodb",
    cmds         => [
-      qw(--execute --alter-foreign-keys-method none --alter ENGINE=INNODB)
+      qw(--execute --alter-foreign-keys-method none --force --alter ENGINE=INNODB)
    ],
 );