Created by Brian Fraser and last modified
Get this branch:
bzr branch lp:~percona-toolkit-dev/percona-toolkit/pt-diskstats-2.0
Members of Percona Toolkit developers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Recent revisions

158. By Brian Fraser

Merged Baron's doc branch, updated tests.

157. By Brian Fraser

Applied Baron's patch, which changes how qtime and stime are calculated.

Also includes a second attempt at fixing the $Diskstats::printed_lines bug,
and fixed how the timestamp is chosen if --show-timestamps is in effect.

156. By Brian Fraser

Merge with Baron's branch, and changes as per the new spec/docs.

155. By Brian Fraser

Moved the calculation of {read,write}_ios_sec around a bit and marked it as TODO

154. By Brian Fraser

Fixed a 'Use of uninitialized value' error in Diskstats->print_deltas()

It's not clear to me how this can even happen, as the variable is
package-scoped and set during compilation, but this should fix it.

153. By Brian Fraser

Tweaks requested by Baron, plus fixes.

* --headers command line option, which can be used to
        enable/disable the automatic headers, and the
        automatic empty lines between samples.
* --show-timestamps, which changes the #ts line with
        a timestamp in the HH:MM:SS format.
* Always use ReadKeyMini, even when we have Term::ReadKey.
        In the latter case, use the Term::ReadKey functions,
        but if they fail, try again with our own versions.

Looks like I forgot to actually enable the "save the current, first
and last" samples. This is now on. It should mean faster and better
output when changing --group-by modes.

152. By Brian Fraser

Change how Diskstats waits for its first handful of samples.

This fixes two bugs -- One a rounding error, one a desyncronization
between the main program and the data gathering daemon.

Additionally, it changes how the daemon prints the very first
sample. Before it would unconditionally wait until the time was
%$sample-time, which meant that in a worst case scenario,
a user could be left waiting for a while before seeing a line
of output.
This commit changes that first wait to only sleep if less
than 20% away from %$sample-time.

151. By Brian Fraser

More fixes as per Baron's review.

150. By Brian Fraser

Merge from Baron's doc branch

149. By Brian Fraser

Several fixes & changes:

* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.