Merge lp:~percona-toolkit-dev/percona-toolkit/pt-archiver-skipping-rows-on-partitioned-tables-1376561 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.12
Proposed by
Frank Cizmich
Status: | Merged |
---|---|
Approved by: | Daniel Nichter |
Approved revision: | 629 |
Merged at revision: | 630 |
Proposed branch: | lp:~percona-toolkit-dev/percona-toolkit/pt-archiver-skipping-rows-on-partitioned-tables-1376561 |
Merge into: | lp:~percona-toolkit-dev/percona-toolkit/release-2.2.12 |
Diff against target: |
58 lines (+15/-4) 4 files modified
bin/pt-archiver (+11/-0) t/pt-archiver/basics.t (+1/-1) t/pt-archiver/indexes.t (+1/-1) t/pt-archiver/samples/issue-248.txt (+2/-2) |
To merge this branch: | bzr merge lp:~percona-toolkit-dev/percona-toolkit/pt-archiver-skipping-rows-on-partitioned-tables-1376561 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Nichter | Approve | ||
Review via email: mp+238033@code.launchpad.net |
Description of the change
When ascending a table using an index and the limit clause, returned sets of rows are not technically guaranteed to be disjoint. This problem manifested itself on partitioned tables, causing row skipping.
Fixed by adding an ORDER BY on the selected index columns.
Modified tests to adjust minor output change.
To post a comment you must log in.
One minute detail, otherwise good.