Merge lp:~percona-toolkit-dev/percona-toolkit/meaningful-type-error-fix-bug-946438 into lp:percona-toolkit/2.0

Proposed by Daniel Nichter
Status: Merged
Approved by: Daniel Nichter
Approved revision: 198
Merged at revision: 200
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/meaningful-type-error-fix-bug-946438
Merge into: lp:percona-toolkit/2.0
Diff against target: 14 lines (+5/-0)
1 file modified
bin/pt-query-digest (+5/-0)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/meaningful-type-error-fix-bug-946438
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Review via email: mp+96168@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Nichter (daniel-nichter) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-query-digest'
2--- bin/pt-query-digest 2012-02-23 16:34:17 +0000
3+++ bin/pt-query-digest 2012-03-06 16:28:21 +0000
4@@ -12350,6 +12350,11 @@
5 );
6 };
7 if ( $EVAL_ERROR ) {
8+ if ( $EVAL_ERROR =~ m/perhaps you forgot to load/ ) {
9+ # There is no module to handle --type, so wrong --type
10+ die "'$module' is not a valid input type. "
11+ . "Please check the documentation for --type.\n";
12+ }
13 die "Failed to load $module module: $EVAL_ERROR";
14 }
15

Subscribers

People subscribed via source and target branches