Merge lp:~percona-toolkit-dev/percona-toolkit/fixed-various-test-issues-1365085 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.11

[Frank Cizmich]

t/lib/Percona/Toolkit.t :

Created an aux function to correctly sort version numbers (some bzr versions do not do it).
This enables the test to correctly fetch the latest version number from the tags.

t/pt-duplicate-key-checker/standard_options.t :

Sometimes the test command hanged. Set a timeout of 5 seconds

t/pt-fifo-split/pt-fifo-split.t :

Sometimes freezes on CentOS despite the coded precautions. Resorted to simply sleeping 3 seconds to avoid deadlock.

[Daniel Nichter (daniel-nichter)]

I don't really understand the problems and thus fixes, but you know more about the tests than me, so if it works for you then great.

review: Approve

=== modified file 't/lib/Percona/Toolkit.t'
--- t/lib/Percona/Toolkit.t	2013-08-08 19:34:29 +0000
+++ t/lib/Percona/Toolkit.t	2014-09-08 20:20:20 +0000
@@ -75,6 +75,8 @@
       unless $root eq $trunk;
    
    my @tags          = split /\n/, `$bzr tags`;
+   # sort the version numbers (some bzr versions do not sort them)
+   @tags = sort { calc_value($a) <=> calc_value($b) } @tags; 
    my ($current_tag) = $tags[-1] =~ /^(\S+)/;
 
    is(
@@ -84,4 +86,18 @@
    );
 }
 
+# we use this function to help sort version numbers
+sub calc_value {
+   my $version = shift;
+   $version =~ s/ +[^ ]*$//;
+   my $value = 0;
+   my $exp = 0;
+   foreach my $num (reverse split /\./, $version) {
+      $value += $num * 10 ** $exp++;
+   }
+   print "$version = $value\n";
+   return $value;
+}
+
+
 done_testing;

=== modified file 't/pt-duplicate-key-checker/standard_options.t'
--- t/pt-duplicate-key-checker/standard_options.t	2013-12-12 02:17:16 +0000
+++ t/pt-duplicate-key-checker/standard_options.t	2014-09-08 20:20:20 +0000
@@ -28,7 +28,32 @@
 
 diag(`touch $pid_file`);
 
-$output = `$cmd -d issue_295 --pid $pid_file 2>&1`;
+
+# to test this issue I must set a timeout in case the command doesn't come back 
+
+eval {
+   # we define an alarm signal handler
+   local $SIG{'ALRM'} = sub { die "timed out\n" }; 
+
+   # and set the alarm 'clock' to 5 seconds
+   alarm(5);  
+
+   # here's the actual command. correct bahaviour is to die with messsage "PID file <pid_file> exists"
+   # Incorrect behavior is anything else, including not returning control after 5 seconds
+   $output = `$cmd -d issue_295 --pid $pid_file 2>&1`;
+
+};
+
+if ($@) {
+        if ($@ eq "timed out\n") {
+                print "I timed out\n";
+        }
+        else {
+                print "Something else went wrong: $@\n";
+        }
+}
+
+
 like(
    $output,
    qr{PID file $pid_file exists},

=== modified file 't/pt-fifo-split/pt-fifo-split.t'
--- t/pt-fifo-split/pt-fifo-split.t	2013-03-04 19:06:34 +0000
+++ t/pt-fifo-split/pt-fifo-split.t	2014-09-08 20:20:20 +0000
@@ -47,6 +47,12 @@
    my ($n_reads) = @_;
    my $last_inode = 0;
    my @data;
+
+   # This test still freezes on some centos systems, 
+   # so we're going to bluntly sleep for a few secs to avoid deadlock 
+   # TODO: figure out if there is a proper way to do this. 
+   sleep(3);
+
    for (1..$n_reads) {
       PerconaTest::wait_until(sub {
          my $inode;