Merge lp:~percona-toolkit-dev/percona-toolkit/fix-ryans-bug-1168110 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.4

Proposed by Daniel Nichter
Status: Merged
Merged at revision: 597
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/fix-ryans-bug-1168110
Merge into: lp:~percona-toolkit-dev/percona-toolkit/release-2.2.4
Diff against target: 15 lines (+3/-3)
1 file modified
bin/pt-variable-advisor (+3/-3)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/fix-ryans-bug-1168110
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Review via email: mp+171910@code.launchpad.net
To post a comment you must log in.
597. By Daniel Nichter

Change advice for key_buffer_size.

Revision history for this message
Daniel Nichter (daniel-nichter) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-variable-advisor'
2--- bin/pt-variable-advisor 2013-06-25 22:32:19 +0000
3+++ bin/pt-variable-advisor 2013-06-27 20:56:27 +0000
4@@ -5519,9 +5519,9 @@
5
6 severity: warn
7
8-The key buffer size is unconfigured. In a production
9-environment it should always be configured explicitly, and the default
10-8MB size is not good.
11+The key buffer size is set to its default value, which is not good
12+for most production systems. In a production environment, key_buffer_size
13+should be larger than the default 8MB size.
14
15 =item large_pages
16

Subscribers

People subscribed via source and target branches

to all changes: