lp:~percona-toolkit-dev/percona-toolkit/fix-953141-recursion-method-array

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:percona-toolkit/2.1 at revision 345

Daniel Nichter: Approve on 2012-08-02

Diff: 2941 lines (+985/-554)

12 files modified

bin/pt-archiver (+76/-41)
bin/pt-heartbeat (+99/-54)
bin/pt-kill (+79/-44)
bin/pt-online-schema-change (+100/-54)
bin/pt-query-digest (+76/-41)
bin/pt-slave-find (+97/-56)
bin/pt-slave-restart (+97/-56)
bin/pt-table-checksum (+102/-57)
bin/pt-table-sync (+94/-56)
lib/MasterSlave.pm (+80/-44)
t/lib/MasterSlave.t (+71/-49)
t/pt-table-checksum/option_sanity.t (+14/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #953141: pt-table-checksum ignores its default and explicit --recursion-method

Medium

Fix Released

Link a bug report

Related blueprints

337. By Daniel Nichter on 2012-08-02

Pass a placeholder for Quoter since it's not needed.

336. By Daniel Nichter on 2012-08-02

Create MasterSlave with required args.

335. By Daniel Nichter on 2012-08-02

Rewrite how MasterSlave handles --recursion-methods.

334. By Brian Fraser on 2012-08-02

t/lib/MasterSlave.t: A call to ->recurse_to_slaves() still used a string instead of an arrayref

333. By Brian Fraser <email address hidden> on 2012-08-01

Update all modules that use --recursion-method, additionally changing it to an array with default processlist,hosts and checking the array for validity

332. By Brian Fraser <email address hidden> on 2012-08-01

MasterSlave: Rework how the recursion methods are checked & resolved

In part by removing the OptionParser usage out from get_slaves
and recurse_to_slaves and making them expect arrayrefs, thus
forcing our callers to deal with that, and in part by
splitting out the method-checking to MasterSlave::check_recursion_method
and the resolving (originally in find_slave_hosts) into
_resolve_recursion_methods.

331. By Brian Fraser on 2012-07-27

Removed the charset munging and made a note in the pt-archiver docs that the only legal charsets are those known by MySQL

330. By Brian Fraser on 2012-07-23

t/pt-table-sync/wait.t: use wait_until() instead of sleep()

329. By Brian Fraser on 2012-07-23

t/lib/Daemon.t: Tweak the tests to hopefully avoid white smoke

328. By Brian Fraser on 2012-07-23

t/lib/MasterSlave.t: Check that recurse_to_slaves gets all three slaves, or give a diagnostic