Merge lp:~percona-toolkit-dev/percona-toolkit/fix-885382 into lp:percona-toolkit/2.1
Proposed by
Brian Fraser
Status: | Merged |
---|---|
Merged at revision: | 271 |
Proposed branch: | lp:~percona-toolkit-dev/percona-toolkit/fix-885382 |
Merge into: | lp:percona-toolkit/2.1 |
Diff against target: |
90 lines (+51/-4) 2 files modified
bin/pt-query-digest (+14/-2) t/pt-query-digest/option_sanity.t (+37/-2) |
To merge this branch: | bzr merge lp:~percona-toolkit-dev/percona-toolkit/fix-885382 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Fraser (community) | Approve | ||
Daniel Nichter | Approve | ||
Review via email:
|
To post a comment you must log in.
The option's value should be validated earlier, just after creating the OptionParser, so the tool doesn't get started only to die later. So instead of die() it will be $o->save_error().
It might also be nice to qr// the option's two values to ensure that they're valid regex.
Given that, the test in bugs.t can be moved to option_sanity.t.