lp:~percona-toolkit-dev/percona-toolkit/fix-823431-pqa-hangs-large-query
Created by
Brian Fraser
and last modified
- Get this branch:
- bzr branch lp:~percona-toolkit-dev/percona-toolkit/fix-823431-pqa-hangs-large-query
Members of
Percona Toolkit developers
can upload to this branch. Log in for directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Daniel Nichter: Approve
- Brian Fraser (community): Approve
-
Diff: 161 lines (+116/-2)4 files modifiedbin/pt-query-advisor (+1/-0)
lib/SQLParser.pm (+1/-0)
t/lib/samples/bug_823431.log (+88/-0)
t/pt-query-advisor/parse_logs.t (+26/-2)
Related bugs
Bug #823431: pt-query-advisor hangs on big queries | Medium | Fix Released |
Related blueprints
Branch information
- Owner:
- Percona Toolkit developers
- Status:
- Merged
Recent revisions
- 441. By Brian Fraser
-
Fix for 823431: pt-query-advisor hangs on big queries
This was caused by a regex backtracking itself to a halt. The solution
was to add a positive lookahead that searches for the floating but mandatory
substrings that the regex needs; if those exist, then eventually it will
match, but if they don't, it'll fail quickly. - 433. By Daniel Nichter
-
Don't use literal values for t/pt-heartbeat/
basics. t 'It is being updated' test. Use direct call rather than backticks.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:percona-toolkit/2.1