Merge lp:~percona-toolkit-dev/percona-toolkit/doc-patch-empty-replicate-table-1074179 into lp:percona-toolkit/2.1

Proposed by Brian Fraser on 2012-11-16
Status: Merged
Approved by: Daniel Nichter on 2012-11-30
Approved revision: 462
Merged at revision: 477
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/doc-patch-empty-replicate-table-1074179
Merge into: lp:percona-toolkit/2.1
Diff against target: 13 lines (+3/-0)
1 file modified
bin/pt-table-checksum (+3/-0)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/doc-patch-empty-replicate-table-1074179
Reviewer Review Type Date Requested Status
Daniel Nichter 2012-11-16 Approve on 2012-11-30
Review via email: mp+134670@code.launchpad.net
To post a comment you must log in.
Daniel Nichter (daniel-nichter) wrote :

OptionParser.pm doesn't understand B<> and such so it comes out literally in --help. Rather than change OptionParser, just remove B<>.

"If you truly need to empty the replicate table, you should do a C<TRUNCATE TABLE> prior to running the tool." --> "To empty the entire replicate table, you must manually execute C<TRUNCATE TABLE> before running the tool."

review: Needs Fixing
Brian Fraser (fraserbn) wrote :

Sure, done. In the future, perhaps we should look into calling pod2man on the --help output.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-table-checksum'
2--- bin/pt-table-checksum 2012-11-30 00:10:51 +0000
3+++ bin/pt-table-checksum 2012-11-30 01:50:28 +0000
4@@ -11246,6 +11246,9 @@
5 If you're resuming from a previous checksum run, then the checksum records for
6 the table from which the tool resumes won't be emptied.
7
8+To empty the entire replicate table, you must manually execute C<TRUNCATE TABLE>
9+before running the tool.
10+
11 =item --engines
12
13 short form: -e; type: hash; group: Filter

Subscribers

People subscribed via source and target branches