Merge lp:~percona-toolkit-dev/percona-toolkit/clean-up-pqd-2.2 into lp:percona-toolkit/2.2

Proposed by Daniel Nichter
Status: Merged
Approved by: Daniel Nichter
Approved revision: 546
Merged at revision: 549
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/clean-up-pqd-2.2
Merge into: lp:percona-toolkit/2.2
Diff against target: 0 lines
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/clean-up-pqd-2.2
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Brian Fraser Pending
Review via email: mp+151801@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

pt-query-digest/option_sanity...................ok 4/0Cannot open t/pt-query-digest/samples/stats-slow002.txt: No such file or directory at /Users/daniel/p/clean-up-pqd-2.2/lib/PerconaTest.pm line 213.

review: Needs Fixing
539. By Daniel Nichter

Clean up docs. Clean up t/pt-query-digest/since_until.t. review.t needs to be fixed and cleaned up (i.e. use pt_query_digest::main() instead of shelling out, split off --history tests into history.t, etc.).

540. By Daniel Nichter

Merge Brian's change in r539.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

review.t needs to be fixed and cleaned up.

review: Needs Fixing
541. By Daniel Nichter

Remove --zero-admin; always on now. Change --output=query to =report and update the docs.

542. By Brian Fraser

Make review.t use output() rather than shelling out

543. By Brian Fraser

Move the --history tests out of review.t

544. By Brian Fraser

Fix broken tests

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

http://bazaar.launchpad.net/~percona-toolkit-dev/percona-toolkit/clean-up-pqd-2.2/revision/544

The --[no]zero-admin optino was removed but its affect kept in place, i.e. made always-on, so we should keep the test that verifies that Admin commands have zero values for Row* attributes.

review: Needs Fixing
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Cancel that; my mistake. I read it backwards. I see now that the removed test was for --no-zero-admin.

> http://bazaar.launchpad.net/~percona-toolkit-dev/percona-toolkit/clean-up-
> pqd-2.2/revision/544
>
> The --[no]zero-admin optino was removed but its affect kept in place, i.e.
> made always-on, so we should keep the test that verifies that Admin commands
> have zero values for Row* attributes.

545. By Daniel Nichter

Rename hist.t to history.t.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :
review: Needs Fixing
546. By Brian Fraser

Split the QueryHistory tests out of QueryReview.t

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :
review: Approve
547. By Daniel Nichter

Clean up and fix docs again.

548. By Daniel Nichter

Note that json output is in development. Fix typo.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches