lp:~percona-toolkit-dev/percona-toolkit/changehandler-dont-hexify-text-cols

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:percona-toolkit/2.1 at revision 395

Brian Fraser (community): Approve on 2012-09-19

Daniel Nichter: Pending requested 2012-08-27

Diff: 71 lines (+30/-3)

3 files modified

bin/pt-table-sync (+1/-1)
lib/ChangeHandler.pm (+1/-1)
t/lib/ChangeHandler.t (+28/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1038276: ChangeHandler doesn't quote varchar columns with hex-looking values

Medium

Fix Released

Link a bug report

Related blueprints

383. By Brian Fraser <email address hidden> on 2012-08-27

ChangeHandler: Don't hexify text columns.

As far as I understand, it doesn't make any sense to hexify text
columns; they break in many ways (you can't roundtrip the UTFs,
quote_val gets the hex quoting wrong, etc) and in any case,
the maatkit bugs about the feature are all about blob/binary
columns.

And, while a perilous excercise of genetic programming, removing
it didn't break any pt-table-sync tests, so this commit does
exactly that.

382. By Daniel Nichter on 2012-08-27

Merge fix-bailouts. t/pt-table-sync/issue_22.t needs to be fixed (bug 1038276).

381. By Brian Fraser <email address hidden> on 2012-08-27

Merged fix-942114-bad-find-usage

380. By Daniel Nichter on 2012-08-25

Merge docu-gdb-dep

379. By Brian Fraser on 2012-08-24

Merged fix-1038276-changehandler-hex-looking-vals

378. By Daniel Nichter on 2012-08-24

Merge docu-ptc-rbr-limitation

377. By Brian Fraser on 2012-08-24

Merged quote-tr-arguments

376. By Brian Fraser on 2012-08-24

Merged tablesync-precedence-issue

375. By Brian Fraser on 2012-08-24

Merged fix-1035311-group-by-sample-devices-regex-interaction

374. By Brian Fraser on 2012-08-24

Merged fix-930693-changehandler-whitespace-text-cols