Merge lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727 into lp:percona-toolkit/2.0

Proposed by Baron Schwartz
Status: Merged
Merged at revision: 228
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727
Merge into: lp:percona-toolkit/2.0
Diff against target: 36 lines (+9/-5)
2 files modified
bin/pt-diskstats (+6/-5)
t/pt-query-digest/mirror.t (+3/-0)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Review via email: mp+100172@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

All tests pass.

Revision history for this message
Daniel Nichter (daniel-nichter) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-diskstats'
2--- bin/pt-diskstats 2012-03-07 23:41:54 +0000
3+++ bin/pt-diskstats 2012-03-30 15:35:28 +0000
4@@ -3938,12 +3938,13 @@
5
6 =item --group-by
7
8-type: string; default: disk
9+type: string; default: all
10
11-Group-by mode: disk, sample, or all. In B<disk> mode, each line of output shows
12-one disk device. In B<sample> mode, each line of output shows one sample of
13-statistics. In B<all> mode, each line of output shows one sample and one disk
14-device.
15+Group-by mode: disk, sample, or all. In B<disk> mode, each line of output
16+shows one disk device, with the statistics computed since the tool started. In
17+B<sample> mode, each line of output shows one sample of statistics, with all
18+disks averaged together. In B<all> mode, each line of output shows one sample
19+and one disk device.
20
21 =item --headers
22
23
24=== modified file 't/pt-query-digest/mirror.t'
25--- t/pt-query-digest/mirror.t 2012-03-06 20:23:20 +0000
26+++ t/pt-query-digest/mirror.t 2012-03-30 15:35:28 +0000
27@@ -36,6 +36,9 @@
28 my $pid_file = "/tmp/pt-query-digest-mirror-test.pid";
29 diag(`rm $pid_file 2>/dev/null`);
30
31+my $pid_file = '/tmp/pt-query-digest.test.pid';
32+`rm -rf $pid_file >/dev/null`;
33+
34 # ##########################################################################
35 # Tests for swapping --processlist and --execute
36 # ##########################################################################

Subscribers

People subscribed via source and target branches