Merge lp:~percona-dev/percona-xtradb/fix-bug395784 into lp:~percona-dev/percona-xtradb/extensions-1.0

Proposed by Aleksandr Kuzminsky
Status: Merged
Merged at revision: not available
Proposed branch: lp:~percona-dev/percona-xtradb/fix-bug395784
Merge into: lp:~percona-dev/percona-xtradb/extensions-1.0
Diff against target: None lines
To merge this branch: bzr merge lp:~percona-dev/percona-xtradb/fix-bug395784
Reviewer Review Type Date Requested Status
Vadim Tkachenko Approve
Review via email: mp+8237@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Aleksandr Kuzminsky (akuzminsky) wrote :

[akuzminsky@sm1u02 mysql-test]$ ./mtr innodb_xtradb_bug317074
Logging: ./mtr innodb_xtradb_bug317074
MySQL Version 5.1.36
Checking supported features...
 - skipping ndbcluster, mysqld not compiled with ndbcluster
 - skipping SSL, mysqld not compiled with SSL
Collecting tests...
vardir: /mnt/data1/home/akuzminsky/src/xtradb/bug395784/mysql-5.1.36/mysql-test/var
Removing old var directory...
Creating var directory '/mnt/data1/home/akuzminsky/src/xtradb/bug395784/mysql-5.1.36/mysql-test/var'...
Installing system database...
Using server port 47193

==============================================================================

TEST RESULT TIME (ms)
------------------------------------------------------------

worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
main.innodb_xtradb_bug317074 [ pass ] 69157
------------------------------------------------------------
The servers were restarted 0 times
Spent 69.157 of 71 seconds executing testcases

All 1 tests were successful.

[akuzminsky@sm1u02 mysql-test]$

Revision history for this message
Vadim Tkachenko (vadim-tk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innodb_split_buf_pool_mutex.patch'
2--- innodb_split_buf_pool_mutex.patch 2009-06-24 05:26:28 +0000
3+++ innodb_split_buf_pool_mutex.patch 2009-07-05 17:32:01 +0000
4@@ -3907,18 +3907,49 @@
5
6 mtr_memo_slot_release(mtr, slot);
7
8-diff -ruN innodb_plugin-1.0.3_orig/mysql-test/innodb_xtradb_bug317074.result innodb_plugin-1.0.3_tmp/mysql-test/innodb_xtradb_bug317074.result
9---- /dev/null 1970-01-01 09:00:00.000000000 +0900
10-+++ innodb_plugin-1.0.3_tmp/mysql-test/innodb_xtradb_bug317074.result 2009-06-09 13:58:04.000000000 +0900
11-@@ -0,0 +1,2 @@
12+diff -ruN innodb_plugin-1.0.3_orig/sync/sync0sync.c innodb_plugin-1.0.3_tmp/sync/sync0sync.c
13+--- innodb_plugin-1.0.3_orig/sync/sync0sync.c 2009-02-17 16:56:33.000000000 +0900
14++++ innodb_plugin-1.0.3_tmp/sync/sync0sync.c 2009-06-11 18:59:30.000000000 +0900
15+@@ -1081,6 +1081,12 @@
16+ case SYNC_TRX_SYS_HEADER:
17+ case SYNC_FILE_FORMAT_TAG:
18+ case SYNC_DOUBLEWRITE:
19++ case SYNC_BUF_LRU_LIST:
20++ case SYNC_BUF_FLUSH_LIST:
21++ case SYNC_BUF_PAGE_HASH:
22++ case SYNC_BUF_FREE_LIST:
23++ case SYNC_BUF_ZIP_FREE:
24++ case SYNC_BUF_ZIP_HASH:
25+ case SYNC_BUF_POOL:
26+ case SYNC_SEARCH_SYS:
27+ case SYNC_SEARCH_SYS_CONF:
28+@@ -1107,7 +1113,7 @@
29+ /* Either the thread must own the buffer pool mutex
30+ (buf_pool_mutex), or it is allowed to latch only ONE
31+ buffer block (block->mutex or buf_pool_zip_mutex). */
32+- ut_a((sync_thread_levels_contain(array, SYNC_BUF_POOL)
33++ ut_a((sync_thread_levels_contain(array, SYNC_BUF_LRU_LIST)
34+ && sync_thread_levels_g(array, SYNC_BUF_BLOCK - 1))
35+ || sync_thread_levels_g(array, SYNC_BUF_BLOCK));
36+ break;
37+diff -Nur a/mysql-test/innodb_xtradb_bug317074.result b/mysql-test/innodb_xtradb_bug317074.result
38+--- a/mysql-test/innodb_xtradb_bug317074.result 1970-01-01 00:00:00.000000000 +0000
39++++ b/mysql-test/innodb_xtradb_bug317074.result 2009-07-05 17:28:06.000000000 +0000
40+@@ -0,0 +1,5 @@
41++SET @old_innodb_file_format=@@innodb_file_format;
42++SET @old_innodb_file_per_table=@@innodb_file_per_table;
43++SET @old_innodb_file_format_check=@@innodb_file_format_check;
44 +SET GLOBAL innodb_file_format='Barracuda';
45 +SET GLOBAL innodb_file_per_table=ON;
46-diff -ruN innodb_plugin-1.0.3_orig/mysql-test/innodb_xtradb_bug317074.test innodb_plugin-1.0.3_tmp/mysql-test/innodb_xtradb_bug317074.test
47---- /dev/null 1970-01-01 09:00:00.000000000 +0900
48-+++ innodb_plugin-1.0.3_tmp/mysql-test/innodb_xtradb_bug317074.test 2009-06-09 13:58:04.000000000 +0900
49-@@ -0,0 +1,38 @@
50+diff -Nur a/mysql-test/innodb_xtradb_bug317074.test b/mysql-test/innodb_xtradb_bug317074.test
51+--- a/mysql-test/innodb_xtradb_bug317074.test 1970-01-01 00:00:00.000000000 +0000
52++++ b/mysql-test/innodb_xtradb_bug317074.test 2009-07-05 17:28:06.000000000 +0000
53+@@ -0,0 +1,44 @@
54 +-- source include/have_innodb.inc
55 +
56++SET @old_innodb_file_format=@@innodb_file_format;
57++SET @old_innodb_file_per_table=@@innodb_file_per_table;
58++SET @old_innodb_file_format_check=@@innodb_file_format_check;
59 +SET GLOBAL innodb_file_format='Barracuda';
60 +SET GLOBAL innodb_file_per_table=ON;
61 +
62@@ -3955,28 +3986,6 @@
63 +ALTER TABLE test1 ENGINE=MyISAM;
64 +
65 +DROP TABLE test1;
66-diff -ruN innodb_plugin-1.0.3_orig/sync/sync0sync.c innodb_plugin-1.0.3_tmp/sync/sync0sync.c
67---- innodb_plugin-1.0.3_orig/sync/sync0sync.c 2009-02-17 16:56:33.000000000 +0900
68-+++ innodb_plugin-1.0.3_tmp/sync/sync0sync.c 2009-06-11 18:59:30.000000000 +0900
69-@@ -1081,6 +1081,12 @@
70- case SYNC_TRX_SYS_HEADER:
71- case SYNC_FILE_FORMAT_TAG:
72- case SYNC_DOUBLEWRITE:
73-+ case SYNC_BUF_LRU_LIST:
74-+ case SYNC_BUF_FLUSH_LIST:
75-+ case SYNC_BUF_PAGE_HASH:
76-+ case SYNC_BUF_FREE_LIST:
77-+ case SYNC_BUF_ZIP_FREE:
78-+ case SYNC_BUF_ZIP_HASH:
79- case SYNC_BUF_POOL:
80- case SYNC_SEARCH_SYS:
81- case SYNC_SEARCH_SYS_CONF:
82-@@ -1107,7 +1113,7 @@
83- /* Either the thread must own the buffer pool mutex
84- (buf_pool_mutex), or it is allowed to latch only ONE
85- buffer block (block->mutex or buf_pool_zip_mutex). */
86-- ut_a((sync_thread_levels_contain(array, SYNC_BUF_POOL)
87-+ ut_a((sync_thread_levels_contain(array, SYNC_BUF_LRU_LIST)
88- && sync_thread_levels_g(array, SYNC_BUF_BLOCK - 1))
89- || sync_thread_levels_g(array, SYNC_BUF_BLOCK));
90- break;
91++SET GLOBAL innodb_file_format=@old_innodb_file_format;
92++SET GLOBAL innodb_file_per_table=@old_innodb_file_per_table;
93++SET GLOBAL innodb_file_format_check=@old_innodb_file_format_check;

Subscribers

People subscribed via source and target branches