Merge lp:~percona-dev/percona-xtrabackup/rodrigos_branch into lp:percona-xtrabackup/2.0

[Rodrigo Gadea]

Resubmiting the patch...

[Stewart Smith (stewart)]

looks like you didn't commit or push the fix :)

review: Needs Fixing

[Stewart Smith (stewart)]

review: Approve

[Stewart Smith (stewart)]

causing test failures:

e.g.

http://jenkins.percona.com/view/Percona%20Xtrabackup/job/percona-xtrabackup-param/18/Host=ubuntu-maverick-64bit,xtrabackuptarget=innodb55/testReport/(root)/t_bug606981/sh/

innobackupex: Created backup directory /mnt/workspace/percona-xtrabackup-param/Host/ubuntu-maverick-64bit/xtrabackuptarget/innodb55/test/var/backup
innobackupex: Error: Failed to open file '/tmp/KODaB0I8_r/backup-my.cnf': No such file or directory at /mnt/workspace/percona-xtrabackup-param/Host/ubuntu-maverick-64bit/xtrabackuptarget/innodb55/test/../innobackupex line 359.
2011-06-12 12:12:09: bug606981.sh: ===> innobackupex failed with exit code 0
110612 12:12:09 [Note] /mnt/workspace/percona-xtrabackup-param/Host/ubuntu-maverick-64bit/xtrabackuptarget/innodb55/test/server/bin//mysqld: Normal shutdown

review: Needs Fixing

[Stewart Smith (stewart)]

We've merged another branch that contains these fixes.

Unmerged revisions

255. By Rodrigo Gadea on 2011-05-20

Add File::Temp to handle tmpfiles instead of POSIX "tmpnam"

=== modified file 'innobackupex'
--- innobackupex	2011-05-31 11:17:12 +0000
+++ innobackupex	2011-06-01 01:48:28 +0000
@@ -12,7 +12,7 @@
 use Pod::Usage qw(pod2usage);
 use POSIX "strftime";
 use POSIX ":sys_wait_h";
-use POSIX "tmpnam";
+use File::Temp; # use POSIX "tmpnam";
 use FileHandle;
 use File::Basename;
 use English qw(-no_match_vars);
@@ -148,10 +148,10 @@
 my $mysql_server_version = '';
 
 # name of the file where stderr of mysql process is directed
-my $mysql_stderr = 'stderr';
+my $mysql_stderr = File::Temp->new();
 
 # name of the file where stdout of mysql process is directed
-my $mysql_stdout = 'stdout';
+my $mysql_stdout = File::Temp->new();
 
 # name of the file where binlog position info is written
 my $binlog_info;
@@ -214,6 +214,11 @@
 print_version();
 
 # initialize global variables and perform some checks
+if (!$option_tmpdir){
+    my $tmpdir = File::Temp->newdir();
+    $option_tmpdir = $tmpdir->dirname;
+}
+
 if ($option_copy_back) {
 	if ( $option_ibbackup_binary eq 'autodetect' ) {
 		$option_ibbackup_binary = 'xtrabackup';