Merge lp:~percona-dev/percona-xtrabackup/bug688211 into lp:percona-xtrabackup/2.0

[Alexey Kopytov]

[lp:~percona-dev/percona-xtrabackup/bug688211]

205. By Alexey Kopytov on 2010-12-10

Bug #688211: cannot handle MySQL passwords which contain special
characters

The problem was that all options (not just passwords) were not properly
quoted before passing it to the shell when calling the mysql command
line client.

[Vadim Tkachenko (vadim-tk)]

ok for me

review: Approve

[Alexey Kopytov (akopytov)]

The code changes to innobackupex were merged along with the test cases in MP #44989.

=== modified file 'innobackupex-1.5.1'
--- innobackupex-1.5.1	2010-11-29 17:29:58 +0000
+++ innobackupex-1.5.1	2010-12-10 18:12:04 +0000
@@ -1114,23 +1114,23 @@
 
     # this option has to be first
     if ($option_defaults_file) {
-        $options = "$options --defaults-file=\"$option_defaults_file\"";
+        $options = "$options --defaults-file='$option_defaults_file'";
     }
 
     if ($option_mysql_password) {
-        $options = "$options --password=$option_mysql_password";
+        $options = "$options --password='$option_mysql_password'";
     }
     if ($option_mysql_user) {
-        $options = "$options --user=$option_mysql_user";
+        $options = "$options --user='$option_mysql_user'";
     }
     if ($option_mysql_host) {
-        $options = "$options --host=$option_mysql_host";
+        $options = "$options --host='$option_mysql_host'";
     }
     if ($option_mysql_port) {
-        $options = "$options --port=$option_mysql_port";
+        $options = "$options --port='$option_mysql_port'";
     }
     if ($option_mysql_socket) {
-        $options = "$options --socket=$option_mysql_socket";
+        $options = "$options --socket='$option_mysql_socket'";
     }
     $options = "$options --unbuffered --";
     return $options;