Merge lp:~percona-dev/percona-server/fix-mysql_mysql_upgrade into lp:percona-server/release-5.1.47-11

Proposed by Aleksandr Kuzminsky
Status: Rejected
Rejected by: Aleksandr Kuzminsky
Proposed branch: lp:~percona-dev/percona-server/fix-mysql_mysql_upgrade
Merge into: lp:percona-server/release-5.1.47-11
Diff against target: 40 lines (+33/-0)
1 file modified
mysql-test.diff (+33/-0)
To merge this branch: bzr merge lp:~percona-dev/percona-server/fix-mysql_mysql_upgrade
Reviewer Review Type Date Requested Status
Yasufumi Kinoshita (community) Needs Information
Review via email: mp+26555@code.launchpad.net

Description of the change

Fixed:
Bug #588179: main.mysql fails on 11.0
Bug #588182: main.mysql_upgrade fails on 11.0

To post a comment you must log in.
Revision history for this message
Aleksandr Kuzminsky (akuzminsky) wrote :
Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

The script is not needed in my environment... Is it CentOS5 specific?

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

(not needed to be patched)

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

Anyway I cannot accept but the fix makes main.mysql fails in my environment...

review: Needs Information

Unmerged revisions

23. By Aleksandr Kuzminsky

fix of the fix. bug #588182 and #588179

22. By Aleksandr Kuzminsky

Fixed Bug #588182 and Bug #588179

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mysql-test.diff'
2--- mysql-test.diff 2010-05-28 05:38:53 +0000
3+++ mysql-test.diff 2010-06-02 04:17:22 +0000
4@@ -928,3 +928,36 @@
5 --error 1118
6 CREATE TABLE t1 (
7 c01 CHAR(255), c02 CHAR(255), c03 CHAR(255), c04 CHAR(255),
8+--- a/mysql-test/r/mysql.result 2010-02-11 04:11:48.000000000 -0500
9++++ b/mysql-test/r/mysql.result 2010-02-11 04:18:24.000000000 -0500
10+@@ -162,8 +162,8 @@
11+ ERROR 1049 (42000) at line 1: Unknown database 'invalid'
12+ Test connect with dbname + hostname
13+ Test connect with dbname + _invalid_ hostname
14+-ERROR 2005 (HY000) at line 1: Unknown MySQL server host 'invalid_hostname' (errno)
15+-ERROR 2005 (HY000) at line 1: Unknown MySQL server host 'invalid_hostname' (errno)
16++ERROR 2003 (HY000) at line 1: Can't connect to MySQL server on 'invalid_hostname' (errno)
17++ERROR 2003 (HY000) at line 1: Can't connect to MySQL server on 'invalid_hostname' (errno)
18+ The commands reported in the bug report
19+ ERROR 2005 (HY000) at line 1: Unknown MySQL server host 'cyril has found a bug :)XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX' (errno)
20+ Too long dbname
21+@@ -198,7 +198,7 @@
22+ 1
23+ COUNT (*)
24+ 1
25+-ERROR 2005 (HY000) at line 1: Unknown MySQL server host 'invalid_hostname' (errno)
26++ERROR 2003 (HY000) at line 1: Can't connect to MySQL server on 'invalid_hostname' (errno)
27+ End of 5.0 tests
28+ WARNING: --server-arg option not supported in this configuration.
29+ Warning (Code 1286): Unknown table engine 'nonexistent'
30+--- a/mysql-test/r/mysql_upgrade.result 2010-02-13 16:51:51.000000000 -0500
31++++ b/mysql-test/r/mysql_upgrade.result 2010-02-13 16:52:07.000000000 -0500
32+@@ -94,7 +94,7 @@
33+ mysql.user OK
34+ DROP USER mysqltest1@'%';
35+ Run mysql_upgrade with a non existing server socket
36+-mysqlcheck: Got error: 2005: Unknown MySQL server host 'not_existing_host' (errno) when trying to connect
37++mysqlcheck: Got error: 2003: Can't connect to MySQL server on 'not_existing_host' (errno) when trying to connect
38+ FATAL ERROR: Upgrade failed
39+ set GLOBAL sql_mode='STRICT_ALL_TABLES,ANSI_QUOTES,NO_ZERO_DATE';
40+ mtr.global_suppressions OK

Subscribers

People subscribed via source and target branches

to all changes: