Merge lp:~percona-dev/percona-server/5.5.8-fix-warning-in-query_response_time-tests into lp:~percona-dev/percona-server/5.5.8

Proposed by Oleg Tsarev
Status: Merged
Merged at revision: 70
Proposed branch: lp:~percona-dev/percona-server/5.5.8-fix-warning-in-query_response_time-tests
Merge into: lp:~percona-dev/percona-server/5.5.8
Diff against target: 13 lines (+3/-0)
1 file modified
mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test (+3/-0)
To merge this branch: bzr merge lp:~percona-dev/percona-server/5.5.8-fix-warning-in-query_response_time-tests
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+49048@code.launchpad.net

This proposal supersedes a proposal from 2011-02-08.

Description of the change

Fix warnings on replication and query_response_time tests:

worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
main.percona_query_response_time-replication [ fail ] Found warnings/errors in server log file!
        Test ended at 2011-02-08 20:05:09
line
110208 21:05:07 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system function that may return a different value on the slave. Statement: INSERT INTO t SELECT SLEEP(0.4)
110208 21:05:08 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system function that may return a different value on the slave. Statement: INSERT INTO t SELECT SLEEP(0.4)
110208 21:05:09 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system function that may return a different value on the slave. Statement: INSERT INTO t SELECT SLEEP(0.4)
110208 21:05:09 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system function that may return a different value on the slave. Statement: INSERT INTO t SELECT SLEEP(0.4)
^ Found warnings in /storage/project/percona/08-Feb-2011/5.5.8/Percona-Server-debug/mysql-test/var/log/mysqld.2.err
ok

To post a comment you must log in.
Revision history for this message
Oleg Tsarev (tsarev) wrote : Posted in a previous version of this proposal

Nothing changed for documentation

Revision history for this message
Alexey Kopytov (akopytov) wrote : Posted in a previous version of this proposal
Revision history for this message
Oleg Tsarev (tsarev) wrote : Posted in a previous version of this proposal

Alexey, fixed how described.

Revision history for this message
Alexey Kopytov (akopytov) wrote : Posted in a previous version of this proposal

Can you merge both revisions into a single one?

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Does it require a RN entry? This is a fix for a failing test, looks like user-visible change to me.

Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test'
2--- mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test 2011-01-17 01:49:51 +0000
3+++ mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test 2011-02-09 12:36:46 +0000
4@@ -2,6 +2,9 @@
5 --source include/master-slave.inc
6 --source include/have_binlog_format_statement.inc
7 --source include/have_debug.inc
8+--disable_query_log
9+call mtr.add_suppression("Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system function that may return a different value on the slave. Statement:")
10+--enable_query_log
11 SET SESSION debug="+d,response_time_distribution_log_only_more_300_milliseconds";
12
13 connection master;

Subscribers

People subscribed via source and target branches

to all changes: