Merge lp:~percona-dev/percona-server/5.5-bug814404 into lp:percona-server/5.5

[Yasufumi Kinoshita]

[Stewart Smith (stewart)]

I'm not sure in what situation this could validly occur... are you sure this wouldn't just be covering up the source of the bug?

review: Needs Information

[Stewart Smith (stewart)]

Need feedback and/or test case showing why this fix is correct, setting to work in progress.

[Yasufumi Kinoshita (yasufumi-kinoshita)]

Please look #17532
You blocked fix for billed customer.

[Yasufumi Kinoshita (yasufumi-kinoshita)]

(12:41:53) Yasufumi: What should I based on the explain? give me clue to start to explain.
(12:42:18) Yasufumi: I really don't understand what is needed for the explanation.
(12:42:36) Vadim: ok... let me think...
(12:43:07) Vadim: this code has beed in InnoDB for many years, right ?
(12:43:27) Yasufumi: XtraDB.
(12:43:39) Vadim: this is XtraDB, it was not in InnoDB ?
(12:44:55) Yasufumi: --- a/storage/innodb_plugin/handler/ha_innodb.h
(12:44:55) Yasufumi: +++ b/storage/innodb_plugin/handler/ha_innodb.h
(12:44:55) Yasufumi: @@ -52,6 +52,7 @@
(12:44:55) Yasufumi: innodb_idx_translate_t idx_trans_tbl; /*!< index translation
(12:44:55) Yasufumi: table between MySQL and
(12:44:55) Yasufumi: Innodb */
(12:44:55) Yasufumi: + dict_table_t* ib_table;
(12:44:55) Yasufumi: } INNOBASE_SHARE;
(12:45:12) Yasufumi: (innodb_pass_corrupt_table.patch)
(12:45:35) Vadim: Yasufumi so this assertion was added by you ?
(12:45:39) Yasufumi: Yes.
(12:46:16) Yasufumi: It was too strong. renaming or etc might recreate the dict_table_t.
(12:46:18) Vadim: good, then I think you just should write that this was your assertion, and now you think it is too strong,
(12:46:35) Vadim: I think that will be enough and I will aprove merge

[Vadim Tkachenko (vadim-tk)]

I think Yasufumi's reasoning is enough

review: Approve

=== modified file 'innodb_pass_corrupt_table.patch'
--- innodb_pass_corrupt_table.patch	2011-06-29 09:32:51 +0000
+++ innodb_pass_corrupt_table.patch	2011-07-22 03:00:24 +0000
@@ -822,11 +822,11 @@
 +		DBUG_RETURN(HA_ERR_CRASHED_ON_USAGE);
 +	}
 +
-+	if (share->ib_table) {
-+		ut_a(share->ib_table == ib_table);
-+	} else {
-+		share->ib_table = ib_table;
-+	}
++	share->ib_table = ib_table;
++
++
++
++
 +
  	if (NULL == ib_table) {
  		if (is_part && retries < 10) {