lp:~percona-dev/percona-server/5.1_slow_extended_tests_fixes
- Get this branch:
- bzr branch lp:~percona-dev/percona-server/5.1_slow_extended_tests_fixes
Branch merges
Branch information
- Owner:
- Percona developers
- Status:
- Development
Recent revisions
- 251. By Oleg Tsarev
-
1) Move all tests from mysql-test/
slow_extended. patch to slow_extended. patch.
Now tests in "percona" suite
2) Rename all tests from percoa_slow_extended- X to X name
3) Extract start/stop/grep logic from tests to log_start/log_stop/ log_grep includes
4) Remove tests mysql-test/slow_extended. patch/percona_ slow_extended- use_global_ long_query_ time, because variable "use_global_ long_query_ time" was removed in 5.5 (and logic from this test) available in the slow_query_ log_use_ global_ control.
5) Replace all SLEEP(X) by SET SESSION debug="+d,query_ exec_time_ X" or /* query_exec_time_X */
Also fixes bugs:
bug #794780 - "percona_slow_extended- microseconds_ in_slow_ extended sometimes fails"
bug #803071 - "add command-line variable setup test - log_slow_filter"
bug #803076 - "add command-line variable setup test - log_slow_slave_statement s"
bug #803088 - "fix tests for log_slow_sp_statements:
bug #803093 - "add test for variable "log_slow_timestamp_ every/slow_ query_log_ timestamp_ always" (not command-line version)"
bug #803100 - "fix tests for use_global_log_slow_ control/ slow_query_ log_use_ global_ control"
bug #803110 - "fix tests for slow_query_log_microsecond s_timestamp/ slow_query_ log_timestamp_ precision"
bug #803120 - "log_slow_verbosity ommited command-line tests in 5.5 "
bug #803137 - "rename percona_slow_extended- slave_innodb_ stats.test to percona_ slow_extended- log_slow_ verbosity- innodb. test"
bug #760085 - "main.percona_slow_extended- slave_innodb_ stats fails sporadically in 5.1.56 "
bug #803140 - "percona_slow_extended- min_examined_ row_limit. test incorrect" - 250. By Oleg Tsarev
-
Fixes for bugs #712393 #803867
1) I move query_response_time_collect call from intermediate of log_slow_statement to begin.
Reason of bug #712393 - log_slow_statement exit before call query_response_time_collect
2) I move all DBUG_EXECUTE_IF (what used in percona_query_response_ time.test) from response_ time_distributi on.patch to slow_extended.patch
This functionality requires in the slow_extended sporadic fails
3) If we set "debug" variable:
SET [SESSION|GLOBAL] debug="+d,query_ exec_time_ debug"
we can setup exact query_exec_time through set "debug" variable:
SET [SESSION|GLOBAL] debug="+d,query_ exec_time_ TIMES";
where TIMES is [0.31|0.32|0.33| 0.34|0. 35|0.36| 0.37|0. 38|0.39| 0.4|0.5| 1.1|1.2| 1.3|1.4| 1.5|2.1| 2.3|2.5]
After this commit we can also add special comment to the begin of query:
/* query_exec_time="TIMES" */ QUERY;
This changes requires for test SQL_Slave_Thread query execution.
4) I replace logic:
/*------------ ------- ------- ------- ------- */
DBUG_EXECUTE_ IF("query_ exec_time_ debug",
if (query_ execution_ time == 0)
opt_query_ response_ time_stats= 0;
else
opt_query_ response_ time_stats= 1;);
/*------------ ------- ------- ------- ------- */
By following:
/*------------ ------- ------- ------- ------- */
void query_response_time_collect_ with_check( ulonglong query_exec_time)
{
DBUG_ENTER(" query_response_ time_collect_ with_check" );
bool collect= opt_query_response_ time_stats;
DBUG_EXECUTE_ IF("query_ exec_time_ debug",
{
if (0 == query_exec_time)
{
collect= false;
}
});
if(collect)
{
query_response_ time_collect( query_exec_ time);
}
DBUG_VOID_RETURN;
}
/*------------ ------- ------- ------- ------- */
Otherwise debug-code has bad side-effect - set QUERY_RESPONSE_TIME_STATS to OFF if query shouldn't collect
5) I rewrite tests for response_time_distributi on.patch, now all test unified and wouldn't have sporadic fails in the feature.
This change fixes the bug #803867.
6) I also remove mysql-test/response_ time_distributi on.patch and move to patch.
Now this is the suite "percona" and tests "query_response_ time[-[ stored| replication] ]"
7) I also move have_response_time_distributi on.[require| inc] to patch
8) I also add "percona_suite.patch" for include "percona" test suite to default suites list - 244. By Stewart Smith
-
merge valgrind fix for profiling_
slow.patch around enabling of profiling_ use_getrusage - 243. By Stewart Smith
-
regenerate slow_extended.patch to attempt to fix hunk apply failure on CentOS 5 hosts.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:percona-server/5.5