Code review comment for lp:~percona-core/percona-xtradb-cluster/bug-1402166

Alexey Kopytov (akopytov) wrote :

1. if tmp == NULL, but proc.error() returns 0, you will overwrite 'err' with 0. Which is wrong.
2. the MySQL coding stile is 'var= val' (note the space after var)
3. please use my_strerror() instead of strerror().

review: Needs Fixing

« Back to merge proposal