Percona Server moved to https://jira.percona.com/projects/PS

Merge lp:~percona-core/percona-server/t12-ipv6-functions into lp:~percona-core/percona-server/t12

  1. t12-ipv6-functions
  2. Merge into t12
Proposed by George Ormond Lorch III
Status: Merged
Approved by: Sergei Glushchenko
Approved revision: no longer in the source branch.
Merge reported by: George Ormond Lorch III
Merged at revision: not available
Proposed branch: lp:~percona-core/percona-server/t12-ipv6-functions
Merge into: lp:~percona-core/percona-server/t12
To merge this branch: bzr merge lp:~percona-core/percona-server/t12-ipv6-functions
Reviewer Review Type Date Requested Status
Sergei Glushchenko (community) g2 Approve
George Ormond Lorch III (community) Approve
Review via email: mp+191270@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Vlad,

Looks good in general, here are minor comments:

   * diff line 1694 (sql/CMakeLists.txt) : tab used instead of spaces
   * Item_func_inet_aton is declared in item_func.h and implemented in
     item_func.cc, while in MySQL 5.6 and PS 5.6 it is
     declared/implemented in item_inetfunc.h/item_inetfunc.cc. What is
     the reason for it?

review: Needs Fixing (g2)
Revision history for this message
George Ormond Lorch III (gl-az) wrote :

Looks good to me! Pretty straight port from 5.6.

review: Approve
Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> Vlad,
>
> Looks good in general, here are minor comments:
>
> * diff line 1694 (sql/CMakeLists.txt) : tab used instead of spaces
Fixed.

> * Item_func_inet_aton is declared in item_func.h and implemented in
> item_func.cc, while in MySQL 5.6 and PS 5.6 it is
> declared/implemented in item_inetfunc.h/item_inetfunc.cc. What is
> the reason for it?
Item_func_inet_aton was already implemented in 5.5.33 and there were not changes in this function during the whole feature porting. I decided to leave this function as is to minimize changes in patch and possible issues with porting some other features that would touch this code.

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Thank you Vlad. It's reasonable to be as much close to 5.5 as possible.
Approve.

review: Approve (g2)

Subscribers

People subscribed via source and target branches

to all changes: