Code review comment for lp:~peppujols/stellarium/printsky
Revision history for this message
| Bogdan Marinov (daggerstab) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Just a comment - as the feature freeze is in effect, this should be merged only AFTER the release of 0.10.6 this weekend.
Skimming the code, I've noticed several unresolved merge conflicts, with Bazaar conflict markup in the source files.
Pep, if you set Bazaar to use the same e-mail address as the one you use in Launchpad, Launchpad will put a link to your profile page when it lists the revisions that you have committed. (See "Unmerged revisions" bellow: the author is listed as "Propietario", and there is no link.)
I'll build the plug-in and look deeper into the code later.