Merge ~peppepetra/charm-prometheus-grok-exporter:haproxy-metrics into charm-prometheus-grok-exporter:master

Proposed by Giuseppe Petralia
Status: Merged
Merged at revision: 359b47e3a8a3168b18f6ea4a2f774191ac418331
Proposed branch: ~peppepetra/charm-prometheus-grok-exporter:haproxy-metrics
Merge into: charm-prometheus-grok-exporter:master
Prerequisite: ~peppepetra/charm-prometheus-grok-exporter:automatic-config
Diff against target: 35 lines (+19/-0)
2 files modified
files/grok-patterns.yaml (+1/-0)
files/metrics-mapping.yaml (+18/-0)
Reviewer Review Type Date Requested Status
Jeremy Lounder (community) Approve
Review via email: mp+381727@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Assuming these config options work, this looks OK

Revision history for this message
Jeremy Lounder (jldev) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/files/grok-patterns.yaml b/files/grok-patterns.yaml
2index 2abcac3..55267ca 100644
3--- a/files/grok-patterns.yaml
4+++ b/files/grok-patterns.yaml
5@@ -1,3 +1,4 @@
6 grok_patterns:
7 OPENSTACK_API: '%{TIMESTAMP_ISO8601:logdate}%{SPACE}%{NUMBER:pid}?%{SPACE}?%{LOGLEVEL:loglevel} (\[)?(%{NOTSPACE:module})?(\])?%{SPACE}\[%{GREEDYDATA:request}\]%{SPACE}%{NOTSPACE:requesterip}%{SPACE}(%{GREEDYDATA:httpdate})?\"%{NOTSPACE:http_verb}%{SPACE}%{NOTSPACE:url}%{SPACE}(%{NOTSPACE:http_version})?\"%{SPACE}(status:%{SPACE})?%{NUMBER:response}%{SPACE}(len:%{SPACE})?%{NUMBER:response_len}%{SPACE}(time:%{SPACE})?%{NUMBER:response_time}?(%{SPACE}microversion:%{SPACE}%{NUMBER:microversion})?'
8 API_ACCESS: '(%{NOTSPACE:service}%{SPACE})?%{NOTSPACE:requesterip}%{SPACE}-%{SPACE}-%{SPACE}\[%{HTTPDATE:logdate}\]%{SPACE}\"%{NOTSPACE:http_verb}%{SPACE}%{NOTSPACE:url}%{SPACE}%{NOTSPACE:http_version}\"%{SPACE}%{NUMBER:response}%{SPACE}%{NUMBER:response_len}%{GREEDYDATA:client}\"?'
9+ NOVA_COMPUTE: '%{TIMESTAMP_ISO8601:logdate}%{SPACE}%{NUMBER:pid}?%{SPACE}?%{LOGLEVEL:loglevel}%{SPACE}((\[)?(%{NOTSPACE:module})?(\])?%{SPACE})?\[%{GREEDYDATA:request}\]%{SPACE}\[%{GREEDYDATA:resource}\]%{SPACE}%{GREEDYDATA:logmessage}'
10diff --git a/files/metrics-mapping.yaml b/files/metrics-mapping.yaml
11index b435b9e..6cac548 100644
12--- a/files/metrics-mapping.yaml
13+++ b/files/metrics-mapping.yaml
14@@ -97,3 +97,21 @@ metrics:
15 match: '%{API_ACCESS}'
16 labels:
17 response_code: '{{.response}}'
18+ nova_compute_number_of_vms_created:
19+ type: counter
20+ path: /var/log/nova/nova-compute.log
21+ help: Total number of VMs created
22+ match: '%{NOVA_COMPUTE}Instance spawned successfully'
23+ nova_compute_number_of_vms_deleted:
24+ type: counter
25+ path: /var/log/nova/nova-compute.log
26+ help: Total number of VMs deleted
27+ match: '%{NOVA_COMPUTE}Instance destroyed successfully'
28+ haproxy_number_of_tcp_requests:
29+ type: counter
30+ path: /var/log/haproxy.log
31+ help: Number of tcp requests received by haproxy
32+ match: '%{HAPROXYTCP}'
33+ labels:
34+ retries: '{{.retries}}'
35+ server_name: '{{.server_name}}'

Subscribers

People subscribed via source and target branches

to all changes: