Merge ~peppepetra/+git/makefile_spec:makefile_spec into ~peppepetra/+git/makefile_spec:master

[Giuseppe Petralia]

[Alvaro Uria (aluria)]

I've reviewed this change partially. I'll finish later today.

0035343... by Giuseppe Petralia on 2020-07-20

Simplify clean target and make build dependant on submodules

[Drew Freiberger (afreiberger)]

Added comments per our discussion with Jeremy this morning.

review: Needs Fixing

1544aa1... by Giuseppe Petralia on 2020-07-20

Change default values for build, interfaces and layers path
Update max-length-line to 88 (black default)

[Xav Paice (xavpaice)]

Few comments on the exclusions, maybe using .builds rather than 'build', though if it's a regex it'll probably cover the exclusion as is.

I'd be keen to see the clean remove any pyc files from the entire tree, as these often find their way into builds when we're using cp to make them and that'll cause all manner of weird failures in production.

[Giuseppe Petralia (peppepetra)]

Reply inline

66b6a02... by Giuseppe Petralia on 2020-07-21

Update coverage to exclude .builds/

[Drew Freiberger (afreiberger)]

minor nit on build step cp command.

review: Needs Fixing

e737933... by Giuseppe Petralia on 2020-07-21

Ignore charm proof errors raised for non reactive charms.
Use cp -a for non reactive charms when copying to build dir.
Remove dependency on submodules target for release target for operator Makefile.

82d1917... by Giuseppe Petralia on 2020-07-22

Update git submodule cmd to pull latest updates.

8f40cc6... by Giuseppe Petralia on 2020-07-22

Exclude .builds from flake8 checks.

f5964df... by Giuseppe Petralia on 2020-07-22

Remove build dependency on submodules target.
Avoid pulling latest updates where running "make submodules" and
stick with versions set on .gitsubmodules.

c1397a8... by Giuseppe Petralia on 2020-07-22

Add submodules-update target.

044788f... by Giuseppe Petralia on 2020-07-23

Update build dir to .build.
Not override CHARM_BUILD_DIR if defined by the user.

[Paul Goins (vultaire)]

There's some small diff comments for stuff that actually should be changed...

And then there's some larger comments to reflect recent discussion re: a few issues. I tried my best to represent the different points of view expressed.

Discussion desired, but be careful; this could easily devolve into bikeshedding. I'd like for opinions to be expressed, but ultimately we may just need a decision made for the sake of moving forward.

review: Needs Fixing

[Chris Sanders (chris.sanders)]

Be aware Openstack is not the only team we run infrastructure for anymore. K8s charms are increasingly common and they do not follow the Openstack naming conventions they use tox + pytest I believe with other test libraries. It's possible there is a convention from the Charmcraft team we could adopt?

I wouldn't put a lot of time/effort into trying to match every other team as long as we pick something and stick to it. There are several comments/discussions here that are kind of nitpicks and we should be mindful to not spend significant effort rearranging files with little benefit.

I don't want anyone to take that to mean 'leave it as it is' simply let's be mindful the amount of time we put into things based on the value they will bring.

[Joe Guo (guoqiao)]

some inline comments.

[Paul Goins (vultaire)]

Added a few comments re: the discussion.

095618c... by Giuseppe Petralia on 2020-07-31

Address reviews comments

[Giuseppe Petralia (peppepetra)]

Replied inline to comments

69dd487... by Giuseppe Petralia on 2020-07-31

Add support for src folder for reactive charms.

56290ad... by Giuseppe Petralia on 2020-07-31

Update report folder to match gitignore

[Giuseppe Petralia (peppepetra)]

One comment inline

[Paul Goins (vultaire)]

More suggestions, re: "make clean" specifically. It likely affects all the Makefiles, but I just commented once.

review: Needs Fixing

[Paul Goins (vultaire)]

Found another bit which I think ought to be changed.

review: Needs Fixing

b1b36f6... by Giuseppe Petralia on 2020-08-03

Exclude .idea from git clean
Add black reformat target
Add repo-info and version files creation.

[Alvaro Uria (aluria)]

Overall, it lgtm. However, I've added a question about using "git clean" passing "-f" twice instead of once.

78dd92e... by Giuseppe Petralia on 2020-08-03

Add juju cookies file to gitignore.

[Paul Goins (vultaire)]

I think this needs to be fixed; I encountered this on a charm which was being ported from nosetests to unittest discover.

review: Needs Fixing

f5832bf... by Giuseppe Petralia on 2020-08-07

Run charm proof on build.

Unmerged commits

f5832bf... by Giuseppe Petralia on 2020-08-07

Run charm proof on build.

78dd92e... by Giuseppe Petralia on 2020-08-03

Add juju cookies file to gitignore.

b1b36f6... by Giuseppe Petralia on 2020-08-03

Exclude .idea from git clean
Add black reformat target
Add repo-info and version files creation.

56290ad... by Giuseppe Petralia on 2020-07-31

Update report folder to match gitignore

69dd487... by Giuseppe Petralia on 2020-07-31

Add support for src folder for reactive charms.

095618c... by Giuseppe Petralia on 2020-07-31

Address reviews comments

044788f... by Giuseppe Petralia on 2020-07-23

Update build dir to .build.
Not override CHARM_BUILD_DIR if defined by the user.

c1397a8... by Giuseppe Petralia on 2020-07-22

Add submodules-update target.

f5964df... by Giuseppe Petralia on 2020-07-22

Remove build dependency on submodules target.
Avoid pulling latest updates where running "make submodules" and
stick with versions set on .gitsubmodules.

8f40cc6... by Giuseppe Petralia on 2020-07-22

Exclude .builds from flake8 checks.

diff --git a/.gitignore b/.gitignore
index e1bb8bf..6f1f367 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,7 @@
 # Juju files
 .unit-state.db
+.go-cookies
+
 layers/*
 interfaces/*
 
@@ -26,6 +28,7 @@ htmlcov/
 
 # version data
 repo-info
+version
 
 # Python builds
 deb_dist/
@@ -33,3 +36,6 @@ dist/
 
 # Snaps
 *.snap
+
+# Builds
+.build/
\ No newline at end of file
diff --git a/.jujuignore b/.jujuignore
new file mode 100644
index 0000000..b7f1399
--- /dev/null
+++ b/.jujuignore
@@ -0,0 +1 @@
+.build
\ No newline at end of file
diff --git a/Makefile.non_reactive b/Makefile.non_reactive
new file mode 100644
index 0000000..7e1e684
--- /dev/null
+++ b/Makefile.non_reactive
@@ -0,0 +1,75 @@
+PYTHON := /usr/bin/python3
+
+PROJECTPATH=$(dir $(realpath $(MAKEFILE_LIST)))
+ifndef CHARM_BUILD_DIR
+	CHARM_BUILD_DIR=${PROJECTPATH}.build
+endif
+METADATA_FILE="metadata.yaml"
+CHARM_NAME=$(shell cat ${PROJECTPATH}/${METADATA_FILE} | grep -E '^name:' | awk '{print $$2}')
+
+help:
+	@echo "This project supports the following targets"
+	@echo ""
+	@echo " make help - show this text"
+	@echo " make clean - remove unneeded files"
+	@echo " make submodules - make sure that the submodules are up-to-date"
+	@echo " make submodules-update - update submodules to latest changes on remote branch"
+	@echo " make build - build the charm"
+	@echo " make release - run clean and build targets"
+	@echo " make lint - run flake8 and black --check"
+	@echo " make black - run black and reformat files"
+	@echo " make proof - run charm proof"
+	@echo " make unittests - run the tests defined in the unittest subdirectory"
+	@echo " make functional - run the tests defined in the functional subdirectory"
+	@echo " make test - run lint, proof, unittests and functional targets"
+	@echo ""
+
+clean:
+	@echo "Cleaning files"
+	@git clean -ffXd -e '!.idea'
+	@echo "Cleaning existing build"
+	@rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}
+
+submodules:
+	@echo "Cloning submodules"
+	@git submodule update --init --recursive
+
+submodules-update:
+	@echo "Pulling latest updates for submodules"
+	@git submodule update --init --recursive --remote --merge
+
+build:
+	@echo "Building charm to base directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+	@-git rev-parse --abbrev-ref HEAD > ./repo-info
+	@-git describe --always > ./version
+	@mkdir -p ${CHARM_BUILD_DIR}/${CHARM_NAME}
+	@cp -a ./* ${CHARM_BUILD_DIR}/${CHARM_NAME}
+
+release: clean build
+	@echo "Charm is built at ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+
+lint:
+	@echo "Running lint checks"
+	@tox -e lint
+
+black:
+	@echo "Reformat files with black"
+	@tox -e black
+
+proof:
+	@echo "Running charm proof"
+	@-charm proof
+
+unittests:
+	@echo "Running unit tests"
+	@tox -e unit
+
+functional: build
+	@echo "Executing functional tests in ${CHARM_BUILD_DIR}"
+	@CHARM_BUILD_DIR=${CHARM_BUILD_DIR} tox -e func
+
+test: lint proof unittests functional
+	@echo "Charm ${CHARM_NAME} has been tested"
+
+# The targets below don't depend on a file
+.PHONY: help submodules submodules-update clean build release lint black proof unittests functional test
diff --git a/Makefile.operator b/Makefile.operator
new file mode 100644
index 0000000..92ded5f
--- /dev/null
+++ b/Makefile.operator
@@ -0,0 +1,78 @@
+PYTHON := /usr/bin/python3
+
+PROJECTPATH=$(dir $(realpath $(MAKEFILE_LIST)))
+ifndef CHARM_BUILD_DIR
+	CHARM_BUILD_DIR=${PROJECTPATH}.build
+endif
+METADATA_FILE="metadata.yaml"
+CHARM_NAME=$(shell cat ${PROJECTPATH}/${METADATA_FILE} | grep -E '^name:' | awk '{print $$2}')
+
+help:
+	@echo "This project supports the following targets"
+	@echo ""
+	@echo " make help - show this text"
+	@echo " make clean - remove unneeded files"
+	@echo " make submodules - make sure that the submodules are up-to-date"
+	@echo " make submodules-update - update submodules to latest changes on remote branch"
+	@echo " make build - build the charm"
+	@echo " make release - run clean, submodules and build targets"
+	@echo " make lint - run flake8 and black --check"
+	@echo " make black - run black and reformat files"
+	@echo " make proof - run charm proof"
+	@echo " make unittests - run the tests defined in the unittest subdirectory"
+	@echo " make functional - run the tests defined in the functional subdirectory"
+	@echo " make test - run lint, proof, unittests and functional targets"
+	@echo ""
+
+clean:
+	@echo "Cleaning files"
+	@git clean -ffXd -e '!.idea'
+	@echo "Cleaning existing build"
+	@rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}
+
+submodules:
+	@echo "Cloning submodules"
+	@git submodule update --init --recursive
+
+submodules-update:
+	@echo "Pulling latest updates for submodules"
+	@git submodule update --init --recursive --remote --merge
+
+build:
+	@echo "Building charm to base directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+	@-git rev-parse --abbrev-ref HEAD > ./repo-info
+	@-git describe --always > ./version
+	@mkdir -p ${CHARM_BUILD_DIR}/${CHARM_NAME}
+	@cp -a ./* ${CHARM_BUILD_DIR}/${CHARM_NAME}
+	@echo "Installing/updating env if requirements.txt exists"
+	@mkdir -p ${CHARM_BUILD_DIR}/${CHARM_NAME}/env/
+	@if [ -f requirements.txt ] ; then pip3 install --target=${CHARM_BUILD_DIR}/${CHARM_NAME}/env -r requirements.txt --upgrade ; fi
+
+release: clean build
+	@echo "Charm is built at ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+
+lint:
+	@echo "Running lint checks"
+	@tox -e lint
+
+black:
+	@echo "Reformat files with black"
+	@tox -e black
+
+proof:
+	@echo "Running charm proof"
+	@-charm proof
+
+unittests:
+	@echo "Running unit tests"
+	@tox -e unit
+
+functional: build
+	@echo "Executing functional tests in ${CHARM_BUILD_DIR}"
+	@CHARM_BUILD_DIR=${CHARM_BUILD_DIR} tox -e func
+
+test: lint proof unittests functional
+	@echo "Tests completed for charm ${CHARM_NAME}."
+
+# The targets below don't depend on a file
+.PHONY: help submodules submodules-update clean build release lint black proof unittests functional test
diff --git a/Makefile.reactive b/Makefile.reactive
new file mode 100644
index 0000000..5416279
--- /dev/null
+++ b/Makefile.reactive
@@ -0,0 +1,80 @@
+PYTHON := /usr/bin/python3
+
+PROJECTPATH=$(dir $(realpath $(MAKEFILE_LIST)))
+ifndef CHARM_BUILD_DIR
+	CHARM_BUILD_DIR=${PROJECTPATH}.build
+endif
+ifndef CHARM_LAYERS_DIR
+	CHARM_LAYERS_DIR=${PROJECTPATH}/layers
+endif
+ifndef CHARM_INTERFACES_DIR
+	CHARM_INTERFACES_DIR=${PROJECTPATH}/interfaces
+endif
+METADATA_FILE="src/metadata.yaml"
+CHARM_NAME=$(shell cat ${PROJECTPATH}/${METADATA_FILE} | grep -E "^name:" | awk '{print $$2}')
+
+help:
+	@echo "This project supports the following targets"
+	@echo ""
+	@echo " make help - show this text"
+	@echo " make clean - remove unneeded files"
+	@echo " make submodules - make sure that the submodules are up-to-date"
+	@echo " make submodules-update - update submodules to latest changes on remote branch"
+	@echo " make build - build the charm"
+	@echo " make release - run clean, submodules, and build targets"
+	@echo " make lint - run flake8 and black --check"
+	@echo " make black - run black and reformat files"
+	@echo " make proof - run charm proof"
+	@echo " make unittests - run the tests defined in the unittest subdirectory"
+	@echo " make functional - run the tests defined in the functional subdirectory"
+	@echo " make test - run lint, proof, unittests and functional targets"
+	@echo ""
+
+clean:
+	@echo "Cleaning files"
+	@git clean -ffXd -e '!.idea'
+	@echo "Cleaning existing build"
+	@rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}
+
+submodules:
+	@echo "Cloning submodules"
+	@git submodule update --init --recursive
+
+submodules-update:
+	@echo "Pulling latest updates for submodules"
+	@git submodule update --init --recursive --remote --merge
+
+build:
+	@echo "Building charm to directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+	@-git rev-parse --abbrev-ref HEAD > ./src/repo-info
+	@CHARM_LAYERS_DIR=${CHARM_LAYERS_DIR} CHARM_INTERFACES_DIR=${CHARM_INTERFACES_DIR} \
+		TERM=linux CHARM_BUILD_DIR=${CHARM_BUILD_DIR} charm build src/
+
+release: clean build
+	@echo "Charm is built at ${CHARM_BUILD_DIR}/${CHARM_NAME}"
+
+lint:
+	@echo "Running lint checks"
+	@cd src && tox -e lint
+
+black:
+	@echo "Reformat files with black"
+	@cd src && tox -e black
+
+proof: build
+	@echo "Running charm proof"
+	@charm proof ${CHARM_BUILD_DIR}/${CHARM_NAME}
+
+unittests:
+	@echo "Running unit tests"
+	@cd src && tox -e unit
+
+functional: build
+	@echo "Executing functional tests in ${CHARM_BUILD_DIR}"
+	@cd src && CHARM_BUILD_DIR=${CHARM_BUILD_DIR} tox -e func
+
+test: lint proof unittests functional
+	@echo "Tests completed for charm ${CHARM_NAME}."
+
+# The targets below don't depend on a file
+.PHONY: help submodules submodules-update clean build release lint black proof unittests functional test
diff --git a/tox.ini_unitpytest_funcpytest b/tox.ini_unitpytest_funcpytest
new file mode 100644
index 0000000..2900ead
--- /dev/null
+++ b/tox.ini_unitpytest_funcpytest
@@ -0,0 +1,70 @@
+[tox]
+skipsdist=True
+skip_missing_interpreters = True
+envlist = lint, unit, func
+
+[testenv]
+basepython = python3
+setenv =
+  PYTHONPATH = {toxinidir}:{toxinidir}/lib/:{toxinidir}/hooks/
+passenv =
+  HOME
+  PATH
+  CHARM_BUILD_DIR
+  PYTEST_KEEP_MODEL
+  PYTEST_CLOUD_NAME
+  PYTEST_CLOUD_REGION
+  PYTEST_MODEL
+  MODEL_SETTINGS
+  HTTP_PROXY
+  HTTPS_PROXY
+  NO_PROXY
+  SNAP_HTTP_PROXY
+  SNAP_HTTPS_PROXY
+
+[testenv:lint]
+commands =
+    flake8
+    black --check --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+    flake8
+    flake8-docstrings
+    flake8-import-order
+    pep8-naming
+    flake8-colors
+
+[flake8]
+exclude =
+    .git,
+    __pycache__,
+    .tox,
+    charmhelpers,
+    mod,
+    .build
+
+max-line-length = 88
+max-complexity = 10
+
+[testenv:black]
+commands =
+    black --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+
+[testenv:unit]
+commands =
+  pytest -v --ignore {toxinidir}/tests/functional \
+           --cov=lib \
+           --cov=reactive \
+           --cov=actions \
+           --cov=hooks \
+           --cov=src \
+           --cov-report=term \
+           --cov-report=annotate:report/annotated \
+           --cov-report=html:report/html
+deps = -r{toxinidir}/tests/unit/requirements.txt
+
+[testenv:func]
+commands = pytest -v --ignore {toxinidir}/tests/unit
+deps = -r{toxinidir}/tests/functional/requirements.txt
diff --git a/tox.ini_unitpytest_funczaza b/tox.ini_unitpytest_funczaza
new file mode 100644
index 0000000..24fb13b
--- /dev/null
+++ b/tox.ini_unitpytest_funczaza
@@ -0,0 +1,71 @@
+[tox]
+skipsdist=True
+skip_missing_interpreters = True
+envlist = lint, unit, func
+
+[testenv]
+basepython = python3
+setenv =
+  PYTHONPATH = {toxinidir}:{toxinidir}/lib/:{toxinidir}/hooks/
+passenv =
+  HOME
+  PATH
+  CHARM_BUILD_DIR
+  PYTEST_KEEP_MODEL
+  PYTEST_CLOUD_NAME
+  PYTEST_CLOUD_REGION
+  PYTEST_MODEL
+  MODEL_SETTINGS
+  HTTP_PROXY
+  HTTPS_PROXY
+  NO_PROXY
+  SNAP_HTTP_PROXY
+  SNAP_HTTPS_PROXY
+
+[testenv:lint]
+commands =
+    flake8
+    black --check --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+    flake8
+    flake8-docstrings
+    flake8-import-order
+    pep8-naming
+    flake8-colors
+
+[flake8]
+exclude =
+    .git,
+    __pycache__,
+    .tox,
+    charmhelpers,
+    mod,
+    .build
+
+max-line-length = 88
+max-complexity = 10
+
+[testenv:black]
+commands =
+    black --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+
+[testenv:unit]
+commands =
+  pytest -v --ignore {toxinidir}/tests/functional \
+           --cov=lib \
+           --cov=reactive \
+           --cov=actions \
+           --cov=hooks \
+           --cov=src \
+           --cov-report=term \
+           --cov-report=annotate:report/annotated \
+           --cov-report=html:report/html
+deps = -r{toxinidir}/tests/unit/requirements.txt
+
+[testenv:func]
+changedir = {toxinidir}/tests/functional
+commands = functest-run-suite {posargs}
+deps = -r{toxinidir}/tests/functional/requirements.txt
diff --git a/tox.ini_unitunittest_funcpytest b/tox.ini_unitunittest_funcpytest
new file mode 100644
index 0000000..cbd4612
--- /dev/null
+++ b/tox.ini_unitunittest_funcpytest
@@ -0,0 +1,64 @@
+[tox]
+skipsdist=True
+skip_missing_interpreters = True
+envlist = lint, unit, func
+
+[testenv]
+basepython = python3
+setenv =
+  PYTHONPATH = {toxinidir}:{toxinidir}/lib/:{toxinidir}/hooks/
+passenv =
+  HOME
+  PATH
+  CHARM_BUILD_DIR
+  PYTEST_KEEP_MODEL
+  PYTEST_CLOUD_NAME
+  PYTEST_CLOUD_REGION
+  PYTEST_MODEL
+  MODEL_SETTINGS
+  HTTP_PROXY
+  HTTPS_PROXY
+  NO_PROXY
+  SNAP_HTTP_PROXY
+  SNAP_HTTPS_PROXY
+
+[testenv:lint]
+commands =
+    flake8
+    black --check --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+    flake8
+    flake8-docstrings
+    flake8-import-order
+    pep8-naming
+    flake8-colors
+
+[flake8]
+exclude =
+    .git,
+    __pycache__,
+    .tox,
+    charmhelpers,
+    mod,
+    .build
+
+max-line-length = 88
+max-complexity = 10
+
+[testenv:black]
+commands =
+    black --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+
+[testenv:unit]
+commands =
+    coverage run -m unittest discover -s {toxinidir}/tests/unit -v
+    coverage report --omit tests/*,mod/*,.tox/*
+    coverage html --omit tests/*,mod/*,.tox/*
+deps = -r{toxinidir}/tests/unit/requirements.txt
+
+[testenv:func]
+commands = pytest -v --ignore {toxinidir}/tests/unit
+deps = -r{toxinidir}/tests/functional/requirements.txt
diff --git a/tox.ini_unitunittest_funczaza b/tox.ini_unitunittest_funczaza
new file mode 100644
index 0000000..4214c14
--- /dev/null
+++ b/tox.ini_unitunittest_funczaza
@@ -0,0 +1,65 @@
+[tox]
+skipsdist=True
+skip_missing_interpreters = True
+envlist = lint, unit, func
+
+[testenv]
+basepython = python3
+setenv =
+  PYTHONPATH = {toxinidir}:{toxinidir}/lib/:{toxinidir}/hooks/
+passenv =
+  HOME
+  PATH
+  CHARM_BUILD_DIR
+  PYTEST_KEEP_MODEL
+  PYTEST_CLOUD_NAME
+  PYTEST_CLOUD_REGION
+  PYTEST_MODEL
+  MODEL_SETTINGS
+  HTTP_PROXY
+  HTTPS_PROXY
+  NO_PROXY
+  SNAP_HTTP_PROXY
+  SNAP_HTTPS_PROXY
+
+[testenv:lint]
+commands =
+    flake8
+    black --check --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+    flake8
+    flake8-docstrings
+    flake8-import-order
+    pep8-naming
+    flake8-colors
+
+[flake8]
+exclude =
+    .git,
+    __pycache__,
+    .tox,
+    charmhelpers,
+    mod,
+    .build
+
+max-line-length = 88
+max-complexity = 10
+
+[testenv:black]
+commands =
+    black --exclude "/(\.eggs|\.git|\.tox|\.venv|\.build|dist|charmhelpers|mod)/" .
+deps =
+    black
+
+[testenv:unit]
+commands =
+    coverage run -m unittest discover -s {toxinidir}/tests/unit -v
+    coverage report --omit tests/*,mod/*,.tox/*
+    coverage html --omit tests/*,mod/*,.tox/*
+deps = -r{toxinidir}/tests/unit/requirements.txt
+
+[testenv:func]
+changedir = {toxinidir}/tests/functional
+commands = functest-run-suite {posargs}
+deps = -r{toxinidir}/tests/functional/requirements.txt