Merge lp:~penguin359/ubuntu/precise/network-manager/fix-for-1005091-precise into lp:ubuntu/precise/network-manager

Proposed by Loren M. Lang on 2012-05-27
Status: Rejected
Rejected by: Stéphane Graber on 2012-06-04
Proposed branch: lp:~penguin359/ubuntu/precise/network-manager/fix-for-1005091-precise
Merge into: lp:ubuntu/precise/network-manager
Diff against target: 12 lines (+1/-1)
1 file modified
debian/ifblacklist_migrate.sh (+1/-1)
To merge this branch: bzr merge lp:~penguin359/ubuntu/precise/network-manager/fix-for-1005091-precise
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Disapprove on 2012-06-04
Ubuntu branches 2012-05-27 Pending
Review via email: mp+107545@code.launchpad.net

Description of the Change

Fixed issue with NetworkManager failing to disable all lines related to network interface when taking over management of the device. Prior to this fix, if IPv6 was employed on the network, it would not disable the inet6 lines for the interface thereby preventing NetworkManager from taking over control of the interface, but still disabling dhcp in the /etc/network/interfaces file.

To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote :

OK; so this one is technically correct but against the wrong branch; Rejected :)

review: Disapprove

Unmerged revisions

163. By Loren M. Lang on 2012-05-27

Fixed issue when installing NetworkManager with IPv6 enabled

When NetworkManager is installed while there are automatic interfaces
with both inet dhcp and inet6 auto (IPv6-enabled) interfaces,
NetworkManager would disable the dhcp lines without disabling the auto
lines for IPv6 preventing NetworkManager from actually taking over
management of the interface.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/ifblacklist_migrate.sh'
2--- debian/ifblacklist_migrate.sh 2012-03-08 13:56:38 +0000
3+++ debian/ifblacklist_migrate.sh 2012-05-27 08:15:24 +0000
4@@ -38,7 +38,7 @@
5 cp $NIF_FILE "$NIF_FILE.bak-${backup_suffix}"
6 for i in $ifaces_to_disable; do
7 echo -n "Disabling interface: $i ... "
8- sed -i -e"/^[[:space:]]*iface[[:space:]]\+$i[[:space:]].*dhcp/,/^[[:space:]]*\(iface\|auto\|mapping\|source\|allow-\)/ { /^[[:space:]]*iface[[:space:]]\+$i[[:space:]].*dhcp/ s/^/#NetworkManager#/; /^[[:space:]]*\(iface\|auto\|mapping\|source\|allow-\)/ ! s/^[^#]/#NetworkManager#/; }" $NIF_FILE
9+ sed -i -e"/^[[:space:]]*iface[[:space:]]\+$i[[:space:]].*\(dhcp\|auto\)/,/^[[:space:]]*\(iface\|auto\|mapping\|source\|allow-\)/ { /^[[:space:]]*iface[[:space:]]\+$i[[:space:]].*\(dhcp\|auto\)/ s/^/#NetworkManager#/; /^[[:space:]]*\(iface\|auto\|mapping\|source\|allow-\)/ ! s/^[^#]/#NetworkManager#/; }" $NIF_FILE
10 echo done.
11 done
12 fi

Subscribers

People subscribed via source and target branches

to all changes: