Merge ~pelpsi/turnip/+git/turnipcake:turnipcake-charm-upgrade-to-focal into ~canonical-launchpad-branches/turnip/+git/turnipcake:master

Proposed by Simone Pelosi
Status: Merged
Approved by: Simone Pelosi
Approved revision: d471d10202bf10296eb514e6d652e12fe7b3af46
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pelpsi/turnip/+git/turnipcake:turnipcake-charm-upgrade-to-focal
Merge into: ~canonical-launchpad-branches/turnip/+git/turnipcake:master
Diff against target: 127 lines (+12/-18)
5 files modified
charm/dependencies.txt (+1/-1)
charm/turnipcake/charmcraft.yaml (+10/-9)
charm/turnipcake/layer.yaml (+0/-5)
charm/turnipcake/metadata.yaml (+1/-0)
charm/turnipcake/reactive/turnipcake.py (+0/-3)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+447759@code.launchpad.net

Commit message

Upgraded Turnipcake charm to focal

Updated layers to the latest versions
Changed series to focal
Removed unnecessary code

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

Blocked by : https://code.launchpad.net/~pelpsi/ols-charm-deps/+git/wheels/+merge/447788

Once the above is merged, charm-wheels must be updated accordingly.

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/dependencies.txt b/charm/dependencies.txt
2index ae7d8f8..df3987d 100644
3--- a/charm/dependencies.txt
4+++ b/charm/dependencies.txt
5@@ -8,4 +8,4 @@ layer/basic git+https://github.com/juju-solutions/layer-basic;revno=baf58223
6 layer/options git+https://github.com/juju-solutions/layer-options;revno=fcdcea4e
7 layer/status git+https://github.com/juju-solutions/layer-status;revno=02658f0f
8
9-charm-wheels git+https://git.launchpad.net/~canonical-launchpad-branches/turnip/+git/dependencies
10+charm-wheels git+https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels
11diff --git a/charm/turnipcake/charmcraft.yaml b/charm/turnipcake/charmcraft.yaml
12index 7d5e014..5f7f595 100644
13--- a/charm/turnipcake/charmcraft.yaml
14+++ b/charm/turnipcake/charmcraft.yaml
15@@ -2,16 +2,16 @@ type: charm
16 bases:
17 - build-on:
18 - name: ubuntu
19- channel: "18.04"
20+ channel: "20.04"
21 architectures: [amd64]
22 run-on:
23 - name: ubuntu
24- channel: "18.04"
25+ channel: "20.04"
26 architectures: [amd64]
27 parts:
28 charm-wheels:
29- source: https://git.launchpad.net/~canonical-launchpad-branches/turnip/+git/dependencies
30- source-commit: "030fe3e51edfe8e8c8b3590b52c4792b21631f01"
31+ source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels
32+ source-commit: "7bcd79fa4fca485eaf15ee9e2ee16f3ab902678d"
33 source-submodules: []
34 source-type: git
35 plugin: dump
36@@ -21,7 +21,7 @@ parts:
37 - "-charm-wheels"
38 interface-http:
39 source: https://github.com/juju-solutions/interface-http
40- source-commit: "4a232c6998a0c7deac0c2362e7a9a4f1c776603b"
41+ source-commit: "632131b1f122daf6fb601fd4c9f1e4dbb1a92e09"
42 source-submodules: []
43 source-type: git
44 plugin: dump
45@@ -33,7 +33,7 @@ parts:
46 - "-layers"
47 interface-nrpe-external-master:
48 source: https://github.com/canonical-ols/nrpe-external-master-interface
49- source-commit: "20b2b9fb80613997cb99b8096040cbba72a0ef0c"
50+ source-commit: "3a195bf592c6b45a58fce0d398ba6921dd0bae3b"
51 source-submodules: []
52 source-type: git
53 plugin: dump
54@@ -45,7 +45,7 @@ parts:
55 - "-layers"
56 layer-apt:
57 source: https://git.launchpad.net/layer-apt
58- source-commit: "cf78622e68fe1ca97eb8993c5adc2616f9e110b9"
59+ source-commit: "76bddfb640ab8767fc7e4a4b73a4a4e781948f34"
60 source-submodules: []
61 source-type: git
62 plugin: dump
63@@ -57,7 +57,7 @@ parts:
64 - "-layers"
65 layer-basic:
66 source: https://github.com/juju-solutions/layer-basic
67- source-commit: "baf582236a7b946da4cd140fd6532a2e0c2774d5"
68+ source-commit: "e3affe74ff0c33e2fbfc560fcd1d873726c40233"
69 source-submodules: []
70 source-type: git
71 plugin: dump
72@@ -81,7 +81,7 @@ parts:
73 - "-layers"
74 layer-status:
75 source: https://github.com/juju-solutions/layer-status
76- source-commit: "02658f0f6b2d29316b79820b206cec532c0459c8"
77+ source-commit: "a7d7b6423db37a47611310039e6ed1929c0a2eab"
78 source-submodules: []
79 source-type: git
80 plugin: dump
81@@ -103,6 +103,7 @@ parts:
82 source: .
83 plugin: reactive
84 build-snaps: [charm]
85+ build-packages: [python3-dev]
86 build-environment:
87 - CHARM_LAYERS_DIR: $CRAFT_STAGE/layers/layer
88 - CHARM_INTERFACES_DIR: $CRAFT_STAGE/layers/interface
89diff --git a/charm/turnipcake/layer.yaml b/charm/turnipcake/layer.yaml
90index 830413b..5f6907b 100644
91--- a/charm/turnipcake/layer.yaml
92+++ b/charm/turnipcake/layer.yaml
93@@ -8,8 +8,3 @@ repo: https://git.launchpad.net/~canonical-launchpad-branches/turnip/+git/turnip
94 options:
95 basic:
96 use_venv: true
97- apt:
98- packages:
99- - python-virtualenv
100- - python-dev
101- - make
102diff --git a/charm/turnipcake/metadata.yaml b/charm/turnipcake/metadata.yaml
103index e48a804..08b5231 100644
104--- a/charm/turnipcake/metadata.yaml
105+++ b/charm/turnipcake/metadata.yaml
106@@ -12,6 +12,7 @@ tags:
107 # https://docs.jujucharms.com/devel/en/authors-charm-metadata#charm-store-fields
108 - network
109 series:
110+ - focal
111 - bionic
112 - xenial
113 subordinate: false
114diff --git a/charm/turnipcake/reactive/turnipcake.py b/charm/turnipcake/reactive/turnipcake.py
115index 97b871f..58c44a4 100644
116--- a/charm/turnipcake/reactive/turnipcake.py
117+++ b/charm/turnipcake/reactive/turnipcake.py
118@@ -35,9 +35,6 @@ def install():
119 set_flag('turnipcake.created_user')
120
121
122-@when('apt.installed.python-virtualenv')
123-@when('apt.installed.python-dev')
124-@when('apt.installed.make')
125 @when('turnipcake.created_user')
126 @when_not('turnipcake.installed')
127 def install_turnipcake():

Subscribers

People subscribed via source and target branches