Merge ~pelpsi/turnip/+git/dependencies:turnip-upgrade-to-focal into ~canonical-launchpad-branches/turnip/+git/dependencies:master
Proposed by
Simone Pelosi
Status: | Rejected |
---|---|
Rejected by: | Simone Pelosi |
Proposed branch: | ~pelpsi/turnip/+git/dependencies:turnip-upgrade-to-focal |
Merge into: | ~canonical-launchpad-branches/turnip/+git/dependencies:master |
Diff against target: |
60 lines (+0/-0) 0 files modified
|
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Needs Information | ||
Review via email: mp+447754@code.launchpad.net |
Commit message
Updated wheels dependencies for focal
Added dependencies required by layer-base
To post a comment you must log in.
I'm not really fond of the way that turnip's dependencies repository conflates dependencies of the payload with dependencies of the charm. Instead of doing this, could you try doing something like this in each of turnip's `charm/ */charmcraft. yaml` files (I haven't tested this): https:/ /paste. ubuntu. com/p/txBh7NZXF B/
If we can manage to remove turnip-dependencies from the charm build process entirely, that would be even better, but I don't know whether that will be straightforwardly possible.