Merge ~pelpsi/launchpad:fetch-service-revocation-endpoint-fix into launchpad:master
Proposed by
Simone Pelosi
Status: | Merged |
---|---|
Approved by: | Simone Pelosi |
Approved revision: | bb3d32f4a9e736135a18baa8884ad41802aaa9f9 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~pelpsi/launchpad:fetch-service-revocation-endpoint-fix |
Merge into: | launchpad:master |
Diff against target: |
29 lines (+3/-3) 2 files modified
lib/lp/buildmaster/builderproxy.py (+2/-2) lib/lp/buildmaster/tests/fetchservice.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ines Almeida | Approve | ||
Review via email: mp+462260@code.launchpad.net |
Commit message
Fix revocation endpoint
fetch_service_
http://{host}:
Fix revocation_endpoint from http://{host}:
http://{host}:
To post a comment you must log in.
Can you be more explicit in the commit message about that this is about the fetch service revocation endpoint?
Also, maybe more of a personal preference, but I would write the structure as something like `http://{host}: {port}/ {session} ` (with some sort of brackets). As it is, you could mean something like `http:// 0.0.0.0: 80/session` because it's not as clear.