lp:~pefarrell/fluidity/fix-intel-12
- Get this branch:
- bzr branch lp:~pefarrell/fluidity/fix-intel-12
Branch merges
Branch information
Recent revisions
- 3956. By Brendan Tollit
-
Remove two test cases that have a memory leak on Precise. This is
linked to bug report:https:/
/bugs.launchpad .net/fluidity/ +bug/963989 and branch:
- 3955. By Brendan Tollit
-
Remove options to use the CV Ultimate limiter from metric advection as the
code does not permit it. Add 2 tests for the advection of a scalar field
using the CV Ultimate limiter as there were none. Both use a P1 FE face
value before limiting. One advects a step change, the other is a copy of
an mms case. Also add the mms case for the CV Sweby limiter for comparison.
For the step advection Ultimate is far better than Sweby but not quite as
sharp as HyperC, which is expected. For the mms test case it was found
necessary to apply a strong BC for the Ultimate limiter case so that
it will converge to a steady state - this however reduces the order
of convergence achieved.No actual code changed, only options schema and test cases.
tests/mms_
tracer_ cv_adv_ steady/ MMS_E_cv. flml is removed as it is not used. Linked to bugs:
https:/
/bugs.launchpad .net/fluidity/ +bug/934250
https://bugs.launchpad .net/fluidity/ +bug/934259 - 3954. By Brendan Tollit
-
Precise build fix for the cv_mass_
matrix_ check_p1 and
cv_mass_matrix_ check_p2 test cases. Issue was actually gmsh. These test cases require a one
element mesh to do some very basic checks of the CV mass
matrix. The gmsh with the precise buildbot doesnt seem to
be able to do that anymore with these .geo files. Therefore
commit the very simple .msh files that do work.Adjust the test Makefile's as required.
- 3950. By Stephan Kramer
-
This deals with bug https:/
/bugs.launchpad .net/fluidity/ +bug/947049 "The script gmsh2triangle tries to identify isolated nodes that are not attached to any elements (isolated nodes) and leaves these out of the output triangle files. This requires a renumbering of the nodes. However this renumbering is only applied to the .ele file but not .edge/.face file. Thus this renumbering only works correctly when the isolated nodes have node numbers that are bigger than any of the boundary nodes. Otherwise the node numbering of the surface mesh and the interior mesh no longer correspond leading to very onobvious errors in fluidity."
Fixed by no longer applying any renumbering. This was decided to be the best fix as gmsh meshes are now also be readable directly by fluidity, in which case isolated nodes would be read as well. So if isolated nodes are present in the input gmsh .msh it's up to the user to fix.
- 3949. By Lawrence Mitchell
-
Avoid memory blowup in update_options
When schema files are read in diamond, the tree-structure is memoised
internally to improve performance. But this comes at the expense of
additional memory use. Previously in update_options we would read the
relevant schema file for every file we were checking. This would
never hit the previously memoised values, since object ids were
different. Instead, build a dictionary of pre-parsed schemas and
just grab the relevant one when checking a file. - 3948. By Tim Greaves
-
r.3947 failed; the system it ran on had an old version of spud/diamond
installed. The Spud 1.1.4 (lp:spud r.520) packages are now out and this is the
result of running tools/update_options. py on a system with those packages
installed.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:fluidity