Ubuntu Push Notifications

Merge lp:~pedronis/ubuntu-push/workaround-13-32bits into lp:ubuntu-push/automatic

  1. workaround-13-32bits
  2. Merge into automatic
Proposed by Samuele Pedroni
Status: Merged
Approved by: John Lenton
Approved revision: 365
Merged at revision: 364
Proposed branch: lp:~pedronis/ubuntu-push/workaround-13-32bits
Merge into: lp:ubuntu-push/automatic
Diff against target: 11 lines (+1/-0)
1 file modified
click/cclick/cclick.go (+1/-0)
To merge this branch: bzr merge lp:~pedronis/ubuntu-push/workaround-13-32bits
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+248937@code.launchpad.net

Commit message

workaround gc issue with 1.3 and 32 bits

Description of the change

workaround gc issue with 1.3 and 32 bits

running client package tests repeatedly doesn't segfault (though now it seems TakeTheBusWorks can get stuck easily on trunk)

To post a comment you must log in.
lp:~pedronis/ubuntu-push/workaround-13-32bits updated
365. By Samuele Pedroni

comment

Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'click/cclick/cclick.go'
2--- click/cclick/cclick.go 2014-07-07 22:04:30 +0000
3+++ click/cclick/cclick.go 2015-02-06 17:01:50 +0000
4@@ -51,6 +51,7 @@
5 }
6 ccu.cref = cref
7 runtime.SetFinalizer(holder, func(interface{}) {
8+ ccu.cref = nil // 1.3 gc gets confused otherwise
9 C.g_object_unref((C.gpointer)(cref))
10 })
11 return nil

Subscribers

People subscribed via source and target branches