Merge lp:~pedronis/ubuntu-push/testlog into lp:ubuntu-push
Proposed by
Samuele Pedroni
Status: | Merged |
---|---|
Approved by: | Samuele Pedroni |
Approved revision: | 54 |
Merged at revision: | 52 |
Proposed branch: | lp:~pedronis/ubuntu-push/testlog |
Merge into: | lp:ubuntu-push |
Diff against target: |
398 lines (+128/-57) 6 files modified
logger/logger.go (+31/-12) logger/logger_test.go (+10/-0) server/broker/simple/suite_test.go (+3/-3) server/broker/testsuite/suite.go (+12/-9) server/listener/listener_test.go (+13/-14) testing/helpers.go (+59/-19) |
To merge this branch: | bzr merge lp:~pedronis/ubuntu-push/testlog |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Lenton (community) | Approve | ||
Review via email:
|
Commit message
base the simple logger only on having a log.Logger-style Output(); given this we can introduce a testing.TestLogger that does redirecting of logs to the gocheck.C object if wired in SetUpTest and also does its own capture
Description of the change
base the simple logger only on having a log.Logger-style Output()
reexport that as we will need it for mgo logging,
given this we can introduce a testing.TestLogger that does redirecting of logs to the gocheck.C object if wired in SetUpTest and also does its own capture.
start using that in the couple of places that were depending on SyncedLogBuffer
To post a comment you must log in.